Lock table in DROP STATISTICS
authorTomas Vondra <tomas.vondra@postgresql.org>
Sun, 19 Nov 2023 20:03:29 +0000 (21:03 +0100)
committerTomas Vondra <tomas.vondra@postgresql.org>
Sun, 19 Nov 2023 20:04:39 +0000 (21:04 +0100)
commit1e468ea4eace4ba150535fba9c752d9ea61e2bdf
tree15880e150cd542529af753c8ff331b19363f0a81
parentb736f06ccfa66b3f920d312799df68d92b0ad35a
Lock table in DROP STATISTICS

The DROP STATISTICS code failed to properly lock the table, leading to

  ERROR:  tuple concurrently deleted

when executed concurrently with ANALYZE.

Fixed by modifying RemoveStatisticsById() to acquire the same lock as
ANALYZE. This function is called only by DROP STATISTICS, as ANALYZE
calls RemoveStatisticsDataById() directly.

Reported by Justin Pryzby, fix by me. Backpatch through 12. The code was
like this since it was introduced in 10, but older releases are EOL.

Reported-by: Justin Pryzby
Reviewed-by: Tom Lane
Backpatch-through: 12

Discussion: https://postgr.es/m/ZUuk-8CfbYeq6g_u@pryzbyj2023
src/backend/commands/statscmds.c