Merge copies of converting an XID to a FullTransactionId.
authorNoah Misch <noah@leadboat.com>
Sat, 25 Jan 2025 19:28:14 +0000 (11:28 -0800)
committerNoah Misch <noah@leadboat.com>
Sat, 25 Jan 2025 19:28:18 +0000 (11:28 -0800)
commit1587f7b9fc1a16df8b01b4f5f9e3c949325160b2
tree3c84d0ddc24c268560aa2ec2a16aaef5fca8387a
parenteca456edc1caf4e93b5d4480b201cd091acede1d
Merge copies of converting an XID to a FullTransactionId.

Assume twophase.c is the performance-sensitive caller, and preserve its
choice of unlikely() branch hint.  Add some retrospective rationale for
that choice.  Back-patch to v17, for the next commit to use it.

Reviewed (in earlier versions) by Michael Paquier.

Discussion: https://postgr.es/m/17821-dd8c334263399284@postgresql.org
Discussion: https://postgr.es/m/20250116010051.f3.nmisch@google.com
contrib/amcheck/verify_heapam.c
src/backend/access/transam/twophase.c
src/backend/access/transam/xlogreader.c
src/backend/utils/adt/xid8funcs.c
src/include/access/transam.h