projects / postgresql.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 642b0b6) | patch
Don't leak malloc'd error string in libpqrcv_check_conninfo().
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 19 Mar 2021 02:21:58 +0000 (22:21 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 19 Mar 2021 02:21:58 +0000 (22:21 -0400)
commit12354839e874c1f6ebc5e1e5ebc1c6b5519eeea0
treeada510459daad8b9e4d205b9790a511f69a54ad3tree
parent642b0b69b0638261fe81dfd9ca3b92927496f1cbcommit | diff
Don't leak malloc'd error string in libpqrcv_check_conninfo().

We leaked the error report from PQconninfoParse, when there was
one.  It seems unlikely that real usage patterns would repeat
the failure often enough to create serious bloat, but let's
back-patch anyway to keep the code similar in all branches.

Found via valgrind testing.
Back-patch to v10 where this code was added.

Discussion: https://postgr.es/m/3816764.1616104288@sss.pgh.pa.us
src/backend/replication/libpqwalreceiver/libpqwalreceiver.c diff | blob | blame | history
This is the main PostgreSQL git repository.