Remove unnecessary complication around xmlParseBalancedChunkMemory.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 29 Jul 2025 16:47:20 +0000 (12:47 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 29 Jul 2025 16:47:20 +0000 (12:47 -0400)
commit0ae824704070dd4beaa77ef8840017ba2601affc
tree2ca3fd76d526d83169a4870f044b205b8c1b239b
parent907ac2ca30bbe7e91959f42f8e420191bb1f2708
Remove unnecessary complication around xmlParseBalancedChunkMemory.

When I prepared 71c0921b6 et al yesterday, I was thinking that the
logic involving explicitly freeing the node_list output was still
needed to dodge leakage bugs in libxml2.  But I was misremembering:
we introduced that only because with early 2.13.x releases we could
not trust xmlParseBalancedChunkMemory's result code, so we had to
look to see if a node list was returned or not.  There's no reason
to believe that xmlParseBalancedChunkMemory will fail to clean up
the node list when required, so simplify.  (This essentially
completes reverting all the non-cosmetic changes in 6082b3d5d.)

Reported-by: Jim Jones <jim.jones@uni-muenster.de>
Author: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/997668.1753802857@sss.pgh.pa.us
Backpatch-through: 13
src/backend/utils/adt/xml.c