Fix sign-compare warnings in pg_iovec.h.
authorNathan Bossart <nathan@postgresql.org>
Fri, 8 Nov 2024 22:11:08 +0000 (16:11 -0600)
committerNathan Bossart <nathan@postgresql.org>
Fri, 8 Nov 2024 22:11:08 +0000 (16:11 -0600)
commit0a883a067bd78f0ff0607afb18c4f783ac764504
tree51dd12f1779175c675bebf5cce44a2ba7f715d97
parent4145ea0910d7bdbf131aa6514ffce8eb92230a5f
Fix sign-compare warnings in pg_iovec.h.

The code in question (pg_preadv() and pg_pwritev()) has been around
for a while, but commit 15c9ac3629 moved it to a header file.  If
third-party code that includes this header file is built with
-Wsign-compare on a system without preadv() or pwritev(), warnings
ensue.  This commit fixes said warnings by casting the result of
pg_pread()/pg_pwrite() to size_t, which should be safe because we
will have already checked for a negative value.

Author: Wolfgang Walther
Discussion: https://postgr.es/m/16989737-1aa8-48fd-8dfe-b7ada06509ab%40technowledgy.de
Backpatch-through: 17
src/include/port/pg_iovec.h