Fix WaitEventSet resource leak in WaitLatchOrSocket().
authorEtsuro Fujita <efujita@postgresql.org>
Thu, 11 Apr 2024 10:05:05 +0000 (19:05 +0900)
committerEtsuro Fujita <efujita@postgresql.org>
Thu, 11 Apr 2024 10:05:05 +0000 (19:05 +0900)
commit01b01a77fe786740ec5e657e5f2ed0a94ab0ac17
tree11b59484c45813d8f763b59a339b9cc6bb3f07bb
parentf5cee411a1903fdad9d60c80022fbe4ad3c4d519
Fix WaitEventSet resource leak in WaitLatchOrSocket().

This function would have the same issue we solved in commit 501cfd07d:
If an error is thrown after calling CreateWaitEventSet(), the file
descriptor (on epoll- or kqueue-based systems) or handles (on Windows)
that the WaitEventSet contains are leaked.

Like that commit, use PG_TRY-PG_FINALLY (PG_TRY-PG_CATCH in v12) to make
sure the WaitEventSet is freed properly.

Back-patch to all supported versions, but as we do not have this issue
in HEAD (cf. commit 50c67c201), no need to apply this patch to it.

Discussion: https://postgr.es/m/CAPmGK16MqdDoD8oatp8SQWaEa4vS3nfQqDN_Sj9YRuu5J3Lj9g%40mail.gmail.com
src/backend/storage/ipc/latch.c