Remove useless casts to Pointer

in arguments of memcpy() and memmove() calls

Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Reviewed-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Discussion: https://www.postgresql.org/message-id/4154950a-47ae-4223-bd01-1235cc50e933%40eisentraut.org

diff --git a/contrib/bloom/blutils.c b/contrib/bloom/blutils.c
index 2c0e71eedc654e4829db62909e4249f60cebbae7..bf50037a71ae566d2eee1af6fa85799262ecf6d8 100644 (file)
--- a/contrib/bloom/blutils.c
+++ b/contrib/bloom/blutils.c
@@ -336,7 +336,7 @@ BloomPageAddItem(BloomState *state, Page page, BloomTuple *tuple)
    /* Copy new tuple to the end of page */
    opaque = BloomPageGetOpaque(page);
    itup = BloomPageGetTuple(state, page, opaque->maxoff + 1);
-   memcpy((Pointer) itup, (Pointer) tuple, state->sizeOfBloomTuple);
+   memcpy(itup, tuple, state->sizeOfBloomTuple);
 
    /* Adjust maxoff and pd_lower */
    opaque->maxoff++;

diff --git a/contrib/bloom/blvacuum.c b/contrib/bloom/blvacuum.c
index 9e5f0574fad2ee05c5097986bdc4a0301e4a7359..920884ca245b1303755dba4f706ec507f01d824d 100644 (file)
--- a/contrib/bloom/blvacuum.c
+++ b/contrib/bloom/blvacuum.c
@@ -94,8 +94,7 @@ blbulkdelete(IndexVacuumInfo *info, IndexBulkDeleteResult *stats,
            {
                /* No; copy it to itupPtr++, but skip copy if not needed */
                if (itupPtr != itup)
-                   memmove((Pointer) itupPtr, (Pointer) itup,
-                           state.sizeOfBloomTuple);
+                   memmove(itupPtr, itup, state.sizeOfBloomTuple);
                itupPtr = BloomPageGetNextTuple(&state, itupPtr);
            }
 

diff --git a/src/backend/access/gin/ginxlog.c b/src/backend/access/gin/ginxlog.c
index 75df3d7a6801e8fa2210554b24a6303c7c4388d3..606741fa396cc209cbe8c0d3f214672cd12f5ef9 100644 (file)
--- a/src/backend/access/gin/ginxlog.c
+++ b/src/backend/access/gin/ginxlog.c
@@ -212,7 +212,7 @@ ginRedoRecompress(Page page, ginxlogRecompressDataLeaf *data)
            if (tailCopy)
            {
                Assert(writePtr + segsize < PageGetSpecialPointer(page));
-               memcpy(writePtr, (Pointer) oldseg, segsize);
+               memcpy(writePtr, oldseg, segsize);
            }
            writePtr += segsize;
            oldseg = GinNextPostingListSegment(oldseg);

diff --git a/src/backend/utils/adt/multirangetypes.c b/src/backend/utils/adt/multirangetypes.c
index 5273b97f7fec5801b726556da69ad8da83bb051e..55e0b4fdc318d5299d79e60a2c5c420e762d6794 100644 (file)
--- a/src/backend/utils/adt/multirangetypes.c
+++ b/src/backend/utils/adt/multirangetypes.c
@@ -629,7 +629,7 @@ write_multirange_data(MultirangeType *multirange, TypeCacheEntry *rangetyp,
        }
        flags[i] = *((Pointer) ranges[i] + VARSIZE(ranges[i]) - sizeof(char));
        len = VARSIZE(ranges[i]) - sizeof(RangeType) - sizeof(char);
-       memcpy(ptr, (Pointer) (ranges[i] + 1), len);
+       memcpy(ptr, ranges[i] + 1, len);
        ptr += att_align_nominal(len, elemalign);
    }
 }