From 3015484483b45e204f41a06a75e35b89485593b8 Mon Sep 17 00:00:00 2001 From: Magnus Hagander Date: Wed, 16 Sep 2020 10:45:03 +0200 Subject: [PATCH] Don't send link to edit deleted submissions Once a submission, like a news article, has been deleted, that link would just become a 404 anyway. --- pgweb/core/views.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pgweb/core/views.py b/pgweb/core/views.py index c52825ad..3f3be58b 100644 --- a/pgweb/core/views.py +++ b/pgweb/core/views.py @@ -322,7 +322,9 @@ def _send_moderation_message(request, obj, message, notice, what): if notice: admmsg += "\n\nModeration notice:\n{}".format(notice) - admmsg += "\n\nEdit at: {}/admin/_moderate/{}/{}/\n".format(settings.SITE_ROOT, obj._meta.model_name, obj.id) + if what != "rejected": + # No point in sending an edit link to a page that doesn't exist anymore + admmsg += "\n\nEdit at: {}/admin/_moderate/{}/{}/\n".format(settings.SITE_ROOT, obj._meta.model_name, obj.id) if obj.twomoderators: modname = "{} and {}".format(obj.firstmoderator, request.user) -- 2.39.5