Remove unnecessary coziness of GIN code with datum copying. Now that

space is tracked via GetMemoryChunkSpace, there's really no advantage
to duplicating datumCopy's innards here.  This is one bit of my toast
indirection patch that should go in anyway.

diff --git a/src/backend/access/gin/ginbulk.c b/src/backend/access/gin/ginbulk.c
index 578e41f15788c95b3133b53d6a99775dc420b8f7..b0e78c3ed8fa82b2a8a929275930cc897b924847 100644 (file)
--- a/src/backend/access/gin/ginbulk.c
+++ b/src/backend/access/gin/ginbulk.c
@@ -78,8 +78,8 @@ ginInsertData(BuildAccumulator *accum, EntryAccumulator *entry, ItemPointer heap
 }
 
 /*
- * This is basically the same as datumCopy(), but we duplicate some code
- * to avoid computing the datum size twice.
+ * This is basically the same as datumCopy(), but modified to count
+ * palloc'd space in accum.
  */
 static Datum
 getDatumCopy(BuildAccumulator *accum, Datum value)
@@ -91,16 +91,8 @@ getDatumCopy(BuildAccumulator *accum, Datum value)
                res = value;
        else
        {
-               Size            realSize;
-               char       *s;
-
-               realSize = datumGetSize(value, false, att[0]->attlen);
-
-               s = (char *) palloc(realSize);
-               accum->allocatedMemory += GetMemoryChunkSpace(s);
-
-               memcpy(s, DatumGetPointer(value), realSize);
-               res = PointerGetDatum(s);
+               res = datumCopy(value, false, att[0]->attlen);
+               accum->allocatedMemory += GetMemoryChunkSpace(DatumGetPointer(res));
        }
        return res;
 }