Use a dash instead of empty string to indicate all tags
authorMagnus Hagander <magnus@hagander.net>
Sat, 26 Sep 2020 13:54:25 +0000 (15:54 +0200)
committerMagnus Hagander <magnus@hagander.net>
Sat, 26 Sep 2020 13:54:25 +0000 (15:54 +0200)
Seems there is somethign in the stack used in production that does not
like the use of an empty string between two slashes...

pgweb/news/views.py
templates/news/newsarchive.html

index f5e85819c9d14e058b1654af25399ce9b8c04519..24522f8d6d3abc32d890079d6dde667720097729 100644 (file)
@@ -15,7 +15,7 @@ NEWS_ITEMS_PER_PAGE = 10
 
 
 def archive(request, tag=None, paginator=None):
-    if tag and tag.strip('/'):
+    if tag and tag.strip('/') != '-':
         tag = get_object_or_404(NewsTag, urlname=tag.strip('/'))
         news = NewsArticle.objects.select_related('org').filter(modstate=ModerationState.APPROVED, tags=tag)
     else:
index 3fab613032d6f0c517f8a57b9cea4f0346b08280..7852455a41ba5dc7860c135751b4315eed60aa7f 100644 (file)
@@ -18,7 +18,7 @@
 {%endfor%}
 
 {%if paginator%}
-<a class="btn btn-primary" href="/about/newsarchive/{{tag.urlname|default:""}}/{{paginator}}/">Older news...</a>
+<a class="btn btn-primary" href="/about/newsarchive/{{tag.urlname|default:"-"}}/{{paginator}}/">Older news...</a>
 {%endif%}
 
 <p>