HeapTupleHeaderAdjustCmax made the incorrect assumption that the raw

command id is the cmin, when it can in fact be a combo cid. That made rows
incorrectly invisible to a transaction where a tuple was deleted by multiple
aborted subtransactions.

Report and patch Karl Schnaitter. Back-patch to 8.3, where combo cids was
introduced.

diff --git a/src/backend/utils/time/combocid.c b/src/backend/utils/time/combocid.c
index cc130806edbafeee0eca24cc58d1d32b465f2c00..cadd7233ca243a5650667afd1d95f43e3ba9cee7 100644 (file)
--- a/src/backend/utils/time/combocid.c
+++ b/src/backend/utils/time/combocid.c
@@ -155,7 +155,7 @@ HeapTupleHeaderAdjustCmax(HeapTupleHeader tup,
        if (!(tup->t_infomask & HEAP_XMIN_COMMITTED) &&
                TransactionIdIsCurrentTransactionId(HeapTupleHeaderGetXmin(tup)))
        {
-               CommandId       cmin = HeapTupleHeaderGetRawCommandId(tup);
+               CommandId       cmin = HeapTupleHeaderGetCmin(tup);
 
                *cmax = GetComboCommandId(cmin, *cmax);
                *iscombo = true;