Reject "ALTER DATABASE/USER ... RESET foo" with invalid GUC name.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 12 Sep 2025 22:10:11 +0000 (18:10 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 12 Sep 2025 22:10:11 +0000 (18:10 -0400)
commit9a71989a8f61d7ee003c443a979a1bd43a08ff63
tree6ab61f6b04b112d1eaf137061d57f7f3fe402a29
parentf14ea34d6e563374cd71b4e7b91cf8d2f60aabb3
Reject "ALTER DATABASE/USER ... RESET foo" with invalid GUC name.

If the database or user had no entry in pg_db_role_setting,
RESET silently did nothing --- including not checking the
validity of the given GUC name.  This is quite inconsistent
and surprising, because you *would* get such an error if there
were any pg_db_role_setting entry, even though it contains
values for unrelated GUCs.

While this is clearly a bug, changing it in stable branches seems
unwise.  The effect will be that some ALTER commands that formerly
were no-ops will now be errors, and people don't like that sort of
thing in minor releases.

Author: Vitaly Davydov <v.davydov@postgrespro.ru>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/30783e-68c28a00-9-41004480@130449754
src/backend/catalog/pg_db_role_setting.c
src/test/modules/unsafe_tests/expected/setconfig.out
src/test/modules/unsafe_tests/sql/setconfig.sql