users/simon/postgres.git
16 years agoNon-Windows EXEC_BACKEND path was broken by recent write_inheritable_socket
Tom Lane [Fri, 28 Aug 2009 17:42:54 +0000 (17:42 +0000)]
Non-Windows EXEC_BACKEND path was broken by recent write_inheritable_socket
change ... it's got to return true.

16 years agoModify the definition of window-function PARTITION BY and ORDER BY clauses
Tom Lane [Thu, 27 Aug 2009 20:08:03 +0000 (20:08 +0000)]
Modify the definition of window-function PARTITION BY and ORDER BY clauses
so that their elements are always taken as simple expressions over the
query's input columns.  It originally seemed like a good idea to make them
act exactly like GROUP BY and ORDER BY, right down to the SQL92-era behavior
of accepting output column names or numbers.  However, that was not such a
great idea, for two reasons:

1. It permits circular references, as exhibited in bug #5018: the output
column could be the one containing the window function itself.  (We actually
had a regression test case illustrating this, but nobody thought twice about
how confusing that would be.)

2. It doesn't seem like a good idea for, eg, "lead(foo) OVER (ORDER BY foo)"
to potentially use two completely different meanings for "foo".

Accordingly, narrow down the behavior of window clauses to use only the
SQL99-compliant interpretation that the expressions are simple expressions.

16 years agoFix broken markup
Alvaro Herrera [Thu, 27 Aug 2009 20:05:28 +0000 (20:05 +0000)]
Fix broken markup

Jan Urbański

16 years agoMake the .DEF file generation rules safe against tabs in exports.txt.
Tom Lane [Thu, 27 Aug 2009 17:55:53 +0000 (17:55 +0000)]
Make the .DEF file generation rules safe against tabs in exports.txt.
Per bug #5016, although I think the MSVC build scripts may need a similar fix.

16 years agoFix handling of autovacuum reloptions.
Alvaro Herrera [Thu, 27 Aug 2009 17:18:44 +0000 (17:18 +0000)]
Fix handling of autovacuum reloptions.

In the original coding, setting a single reloption would cause default
values to be used for all the other reloptions.  This is a problem
particularly for autovacuum reloptions.

Itagaki Takahiro

16 years agoMake it reasonably safe to use pg_ctl to start the postmaster from a boot-time
Tom Lane [Thu, 27 Aug 2009 16:59:38 +0000 (16:59 +0000)]
Make it reasonably safe to use pg_ctl to start the postmaster from a boot-time
script.

To do this, have pg_ctl pass down its parent shell's PID in an environment
variable PG_GRANDPARENT_PID, and teach CreateLockFile() to disregard that PID
as a false match if it finds it in postmaster.pid.  This allows us to cope
with one level of postgres-owned shell process even with pg_ctl in the way,
so it's just as safe as starting the postmaster directly.  You still have to
be careful about how you write the initscript though.

Adjust the comments in contrib/start-scripts/ to not deprecate use of
pg_ctl.  Also, fix the ROTATELOGS option in the OSX script, which was
indulging in exactly the sort of unsafe coding that renders this fix
pointless :-(.  A pipe inside the "sudo" will probably result in more
than one postgres-owned process hanging around.

16 years agoexports.txt needs to use spaces as separators, not tabs, to work properly
Magnus Hagander [Thu, 27 Aug 2009 16:49:41 +0000 (16:49 +0000)]
exports.txt needs to use spaces as separators, not tabs, to work properly
with the sed rules.

16 years agoRemove some unnecessary variable assignments, per results of "clang"
Tom Lane [Thu, 27 Aug 2009 15:59:22 +0000 (15:59 +0000)]
Remove some unnecessary variable assignments, per results of "clang"
static checker.  Paul Matthews

16 years agoIn the checkpoint written at the end of archive recovery, the WAL page header
Heikki Linnakangas [Thu, 27 Aug 2009 07:15:41 +0000 (07:15 +0000)]
In the checkpoint written at the end of archive recovery, the WAL page header
was incorrectly initialized with timeline ID 0. That rendered the WAL page
unrecoverable, making a subsequent archive recovery stop at that point.
ThisTimeLineID needs to be initialized before calling AdvanceXLInsertBuffer().

This fixes bug #5011 reported by James Bardin. Backpatch to 8.4, as the bug
was introduced by the changes to use of bgwriter for writing the
end-of-archive-recovery checkpoint. Patch by Tom Lane.

16 years agoUpdate release notes for 7.4.26, 8.0.22, 8.1.18, 8.2.14, 8.3.8, 8.4.1.
Bruce Momjian [Thu, 27 Aug 2009 01:27:34 +0000 (01:27 +0000)]
Update release notes for 7.4.26, 8.0.22, 8.1.18, 8.2.14, 8.3.8, 8.4.1.

16 years agoUpdate of install-sh, mkinstalldirs, and associated configury
Peter Eisentraut [Wed, 26 Aug 2009 22:24:44 +0000 (22:24 +0000)]
Update of install-sh, mkinstalldirs, and associated configury

Update install-sh to that from Autoconf 2.63, plus our Darwin-specific
changes (which I simplified a bit).  install-sh is now able to install
multiple files in one run, so we could simplify our makefiles sometime.

install-sh also now has a -d option to create directories, so we don't need
mkinstalldirs anymore.

Use AC_PROG_MKDIR_P in configure.in, so we can use mkdir -p when available
instead of install-sh -d.  For consistency with the rest of the world,
the corresponding make variable has been renamed from $(mkinstalldirs) to
$(MKDIR_P).

16 years agoAdd -Wno-error to CFLAGS from gram.o as long as it's broken.
Peter Eisentraut [Wed, 26 Aug 2009 22:15:59 +0000 (22:15 +0000)]
Add -Wno-error to CFLAGS from gram.o as long as it's broken.

16 years agoCorrect my overly enthusiastic CSS simplification.
Peter Eisentraut [Wed, 26 Aug 2009 21:18:29 +0000 (21:18 +0000)]
Correct my overly enthusiastic CSS simplification.

16 years agoUpdate the documentation CSS stylesheet to current web site style
Peter Eisentraut [Wed, 26 Aug 2009 13:56:24 +0000 (13:56 +0000)]
Update the documentation CSS stylesheet to current web site style

16 years agoEnhanced error context support in PL/Python
Peter Eisentraut [Tue, 25 Aug 2009 12:44:59 +0000 (12:44 +0000)]
Enhanced error context support in PL/Python

Extract the "while creating return value" and "while modifying trigger
row" parts of some error messages into another layer of error context.
This will simplify the upcoming patch to improve data type support, but
it can stand on its own.

16 years agoUse generic attribute management in PL/Python
Peter Eisentraut [Tue, 25 Aug 2009 08:14:42 +0000 (08:14 +0000)]
Use generic attribute management in PL/Python

Switch the implementation of the plan and result types to generic attribute
management, as described at <http://docs.python.org/extending/newtypes.html>.
This modernizes and simplifies the code a bit and prepares for Python 3.1,
where the old way doesn't work anymore.

16 years agoMake PL/Python tests more compatible with Python 3
Peter Eisentraut [Mon, 24 Aug 2009 20:25:25 +0000 (20:25 +0000)]
Make PL/Python tests more compatible with Python 3

This changes a bunch of incidentially used constructs in the PL/Python
regression tests to equivalent constructs in cases where Python 3 no longer
supports the old syntax.  Support for older Python versions is unchanged.

16 years agoTry to make silent_mode behave somewhat reasonably.
Tom Lane [Mon, 24 Aug 2009 20:08:32 +0000 (20:08 +0000)]
Try to make silent_mode behave somewhat reasonably.

Instead of sending stdout/stderr to /dev/null after forking away from the
terminal, send them to postmaster.log within the data directory.  Since
this opens the door to indefinite logfile bloat, recommend even more
strongly that log output be redirected when using silent_mode.

Move the postmaster's initial calls of load_hba() and load_ident() down
to after we have started the log collector, if we are going to.  This
is so that errors reported by them will appear in the "usual" place.

Reclassify silent_mode as a LOGGING_WHERE, not LOGGING_WHEN, parameter,
since it's got absolutely nothing to do with the latter category.

In passing, fix some obsolete references to -S ... this option hasn't
had that switch letter for a long time.

Back-patch to 8.4, since as of 8.4 load_hba() and load_ident() are more
picky (and thus more likely to fail) than they used to be.  This entire
change was driven by a complaint about those errors disappearing into
the bit bucket.

16 years agoSmall correction to previous patch: we shouldn't ReleasePostmasterChildSlot
Tom Lane [Mon, 24 Aug 2009 18:09:37 +0000 (18:09 +0000)]
Small correction to previous patch: we shouldn't ReleasePostmasterChildSlot
for a dead_end child, because we didn't AssignPostmasterChildSlot.

16 years agoAvoid calling kill() in a postmaster signal handler.
Alvaro Herrera [Mon, 24 Aug 2009 17:23:02 +0000 (17:23 +0000)]
Avoid calling kill() in a postmaster signal handler.

This causes problems when the system load is high, per report from Zdenek
Kotala in <1250860954.1239.114.camel@localhost>; instead of calling kill
directly, have the signal handler set a flag which is checked in ServerLoop.
This way, the handler can return before being called again by a subsequent
signal sent from the autovacuum launcher.  Also, increase the sleep in the
launcher in this failure path to 1 second.

Backpatch to 8.3, which is when the signalling between autovacuum
launcher/postmaster was introduced.

Also, add a couple of ReleasePostmasterChildSlot calls in error paths; this
part backpatched to 8.4 which is when the child slot stuff was introduced.

16 years agoFix inclusions of readline/editline header files so that we only attempt to
Tom Lane [Mon, 24 Aug 2009 16:18:13 +0000 (16:18 +0000)]
Fix inclusions of readline/editline header files so that we only attempt to
#include the version of history.h that is in the same directory as the
readline.h we are using.  This avoids problems in some scenarios where both
readline and editline are installed.  Report and patch by Zdenek Kotala.

16 years agoRemove unused variable.
Alvaro Herrera [Mon, 24 Aug 2009 14:15:09 +0000 (14:15 +0000)]
Remove unused variable.

Per Grzegorz Jaskiewicz report from LLVM static checker

16 years agoRun the "tablespace" regression test first not last. The former placement
Tom Lane [Mon, 24 Aug 2009 03:10:16 +0000 (03:10 +0000)]
Run the "tablespace" regression test first not last.  The former placement
renders useless one of the few test methodologies we have for WAL replay,
which is to intentionally crash the system just after completing the
regression tests and see if it recovers to the expected database state.
The reason is that DROP TABLESPACE forces a checkpoint, so there's essentially
no WAL available for replay after the tests complete.

16 years agoFix a violation of WAL coding rules in the recent patch to include an
Tom Lane [Mon, 24 Aug 2009 02:18:32 +0000 (02:18 +0000)]
Fix a violation of WAL coding rules in the recent patch to include an
"all tuples visible" flag in heap page headers.  The flag update *must*
be applied before calling XLogInsert, but heap_update and the tuple
moving routines in VACUUM FULL were ignoring this rule.  A crash and
replay could therefore leave the flag incorrectly set, causing rows
to appear visible in seqscans when they should not be.  This might explain
recent reports of data corruption from Jeff Ross and others.

In passing, do a bit of editorialization on comments in visibilitymap.c.

16 years agoMake TRUNCATE do truncate-in-place when processing a relation that was created
Tom Lane [Sun, 23 Aug 2009 19:23:41 +0000 (19:23 +0000)]
Make TRUNCATE do truncate-in-place when processing a relation that was created
or previously truncated in the current (sub)transaction.  This is safe since
if the (sub)transaction later rolls back, we'd just discard the rel's current
physical file anyway.  This avoids unreasonable growth in the number of
transient files when a relation is repeatedly truncated.  Per a performance
gripe a couple weeks ago from Todd Cook.

16 years agoTweak ExecIndexEvalRuntimeKeys to forcibly detoast any toasted comparison
Tom Lane [Sun, 23 Aug 2009 18:26:08 +0000 (18:26 +0000)]
Tweak ExecIndexEvalRuntimeKeys to forcibly detoast any toasted comparison
values before they get passed to the index access method.  This avoids
repeated detoastings that will otherwise ensue as the comparison value
is examined by various index support functions.  We have seen a couple of
reports of cases where repeated detoastings result in an order-of-magnitude
slowdown, so it seems worth adding a bit of extra logic to prevent this.

I had previously proposed trying to avoid duplicate detoastings in general,
but this fix takes care of what seems the most important case in practice
with very little effort or risk.

Back-patch to 8.4 so that the PostGIS folk won't have to wait a year to
have this fix in a production release.  (The issue exists further back,
of course, but the code's diverged enough to make backpatching further a
higher-risk action.  Also it appears that the possible gains may be limited
in prior releases because of different handling of lossy operators.)

16 years agoInclude resjunk columns in EXPLAIN VERBOSE output lists. Per discussion.
Tom Lane [Sat, 22 Aug 2009 02:06:32 +0000 (02:06 +0000)]
Include resjunk columns in EXPLAIN VERBOSE output lists.  Per discussion.

16 years agoRemove tabs from SGML.
Bruce Momjian [Thu, 20 Aug 2009 12:12:37 +0000 (12:12 +0000)]
Remove tabs from SGML.

16 years agoFix version_stamp.pl to allow 'alphaN' version stamps. Not sure how
Tom Lane [Wed, 19 Aug 2009 15:03:56 +0000 (15:03 +0000)]
Fix version_stamp.pl to allow 'alphaN' version stamps.  Not sure how
Peter did that without fixing this ...

16 years agoAlter release note item about PL/pgSQL functions and dropped columns.
Peter Eisentraut [Wed, 19 Aug 2009 08:18:48 +0000 (08:18 +0000)]
Alter release note item about PL/pgSQL functions and dropped columns.
per Pavel Stehule

16 years agoUpdate alpha release notes to current.
Peter Eisentraut [Wed, 19 Aug 2009 07:54:21 +0000 (07:54 +0000)]
Update alpha release notes to current.

16 years agoAllow mixing of traditional and SQL:2008 LIMIT/OFFSET syntax. Being rigid
Tom Lane [Tue, 18 Aug 2009 23:40:20 +0000 (23:40 +0000)]
Allow mixing of traditional and SQL:2008 LIMIT/OFFSET syntax.  Being rigid
about it doesn't simplify the grammar at all, and it does invite confusion
among those who only read the SELECT syntax summary and not the full details.
Per gripe from Jaime Casanova.

16 years agoPick up REGRESS_OPTS from contrib makefiles. Along the way, fix ordering of makefile...
Andrew Dunstan [Tue, 18 Aug 2009 22:36:56 +0000 (22:36 +0000)]
Pick up REGRESS_OPTS from contrib makefiles. Along the way, fix ordering of makefile tests to mimic gmake.

16 years agoFix overflow for INTERVAL 'x ms' where x is more than a couple million,
Tom Lane [Tue, 18 Aug 2009 21:23:14 +0000 (21:23 +0000)]
Fix overflow for INTERVAL 'x ms' where x is more than a couple million,
and integer datetimes are in use.  Per bug report from Hubert Depesz
Lubaczewski.

Alex Hunsaker

16 years agoRemove duplicate from release notes, and reorganize slightly.
Peter Eisentraut [Tue, 18 Aug 2009 16:54:12 +0000 (16:54 +0000)]
Remove duplicate from release notes, and reorganize slightly.

16 years agoPrint the actual DB encoding in the unaccent regression test.
Tom Lane [Tue, 18 Aug 2009 16:00:50 +0000 (16:00 +0000)]
Print the actual DB encoding in the unaccent regression test.
This is to help make it more obvious what the problem is, if the
encoding isn't what the test expects.

16 years agoFix some *other* compiler warnings from a different gcc version.
Tom Lane [Tue, 18 Aug 2009 15:57:26 +0000 (15:57 +0000)]
Fix some *other* compiler warnings from a different gcc version.

16 years agoFix copy-and-pasteo that might explain some of the buildfarm's
Tom Lane [Tue, 18 Aug 2009 15:51:16 +0000 (15:51 +0000)]
Fix copy-and-pasteo that might explain some of the buildfarm's
indigestion about this module.

16 years agoSuppress compiler warnings about uninitialized variables.
Tom Lane [Tue, 18 Aug 2009 15:37:04 +0000 (15:37 +0000)]
Suppress compiler warnings about uninitialized variables.

16 years agoUnaccent dictionary.
Teodor Sigaev [Tue, 18 Aug 2009 10:34:39 +0000 (10:34 +0000)]
Unaccent dictionary.

16 years agoIntroduce filtering dictionary support to tsearch. Propagate --nolocale option
Teodor Sigaev [Tue, 18 Aug 2009 10:30:41 +0000 (10:30 +0000)]
Introduce filtering dictionary support to tsearch.  Propagate --nolocale option
to CREATE DATABASE command in pg_regress to allow correct checking of
locale-sensitive contrib modules.

16 years agoAdd release notes for 8.5alpha1
Peter Eisentraut [Mon, 17 Aug 2009 22:14:44 +0000 (22:14 +0000)]
Add release notes for 8.5alpha1

16 years agoMake version.sgml depend on configure instead of Makefile.global. This
Peter Eisentraut [Mon, 17 Aug 2009 21:29:30 +0000 (21:29 +0000)]
Make version.sgml depend on configure instead of Makefile.global.  This
cheats a bit, but it avoids unsatisfied dependencies in distribution
tarballs.  (found by make distcheck)

16 years agoDepartment of marginal improvements: teach tupconvert.c to avoid doing a
Tom Lane [Mon, 17 Aug 2009 20:34:31 +0000 (20:34 +0000)]
Department of marginal improvements: teach tupconvert.c to avoid doing a
physical conversion when there are dropped columns in the same places in
the input and output tupdescs.  This avoids possible performance loss from
the recent patch to improve dropped-column handling, in some cases where
the old code would have worked.

16 years agoFix imprecise documentation of random(): it never returns 1.0.
Tom Lane [Sun, 16 Aug 2009 19:55:21 +0000 (19:55 +0000)]
Fix imprecise documentation of random(): it never returns 1.0.
This was changed in 8.2 but the documentation was not corrected.
Per gripe from Sam Mason.

16 years agoFix incorrect encoding-aware name truncation in makeArrayTypeName().
Tom Lane [Sun, 16 Aug 2009 18:14:34 +0000 (18:14 +0000)]
Fix incorrect encoding-aware name truncation in makeArrayTypeName().

truncate_identifier won't do anything if the passed-in strlen is already
less than NAMEDATALEN, which it always would be given the strlcpy usage.
This has been broken since the arrays-of-composite-types code went in.

Arguably truncate_identifier is suffering from excessive optimization
and should always process the string, but for the moment I'll take the
more localized patch.

Per bug #4987.

16 years agoRemove Wisconsin benchmark files.
Tom Lane [Sat, 15 Aug 2009 16:16:01 +0000 (16:16 +0000)]
Remove Wisconsin benchmark files.

This test is clearly not being used anymore, since it's been broken for
long periods of time without anyone noticing.  Per discussion, it's not
worth keeping in our source tree.

16 years agoMake sure that 'make distclean' cleans out all files that are not meant
Tom Lane [Sat, 15 Aug 2009 01:56:35 +0000 (01:56 +0000)]
Make sure that 'make distclean' cleans out all files that are not meant
to be shipped.  Also, allow 'make clean' to remove intermediate working files.

16 years agoClarify the documentation about PL/Perl nested subroutines, per Josh
Peter Eisentraut [Sat, 15 Aug 2009 00:33:12 +0000 (00:33 +0000)]
Clarify the documentation about PL/Perl nested subroutines, per Josh
Berkus.

16 years agoRemove the test case that depends on the platform's float output format.
Peter Eisentraut [Fri, 14 Aug 2009 23:25:51 +0000 (23:25 +0000)]
Remove the test case that depends on the platform's float output format.

16 years agoBe able to easily figure out the target directory of "make dist".
Alvaro Herrera [Fri, 14 Aug 2009 21:37:18 +0000 (21:37 +0000)]
Be able to easily figure out the target directory of "make dist".

16 years agoRepair breakage of Wisconsin benchmark due to change of command line syntax
Tom Lane [Fri, 14 Aug 2009 18:49:34 +0000 (18:49 +0000)]
Repair breakage of Wisconsin benchmark due to change of command line syntax
for standalone backends.

Although we probably ought to just remove this long-obsolete test case from
our code, it seems worthwhile to document the issue and fix in CVS first.

Jeff Janes

16 years agoAdd prefix support for synonym dictionary
Teodor Sigaev [Fri, 14 Aug 2009 14:53:20 +0000 (14:53 +0000)]
Add prefix support for synonym dictionary

16 years agoPL/Python regression tests for data type handling
Peter Eisentraut [Fri, 14 Aug 2009 13:42:16 +0000 (13:42 +0000)]
PL/Python regression tests for data type handling

Add some checks on various data types are converted into and out of Python.
This is extracted from Caleb Welton's patch for improved bytea support,
but much expanded.

16 years agoMade sure sqlca is reset for declare cursor in Informix mode as pointed out by
Michael Meskes [Fri, 14 Aug 2009 13:28:22 +0000 (13:28 +0000)]
Made sure sqlca is reset for declare cursor in Informix mode as pointed out by
Böszörményi Zoltán <zb@cybertec.at>.

16 years agoDomain support in PL/Python
Peter Eisentraut [Fri, 14 Aug 2009 13:12:21 +0000 (13:12 +0000)]
Domain support in PL/Python

When examining what Python type to convert a PostgreSQL type to on input,
look at the base type of the input type, otherwise all domains end up
defaulting to string.

16 years agoRemove stray character in type description
Peter Eisentraut [Thu, 13 Aug 2009 21:14:31 +0000 (21:14 +0000)]
Remove stray character in type description

16 years agoAugment test coverage in PL/Python, especially for error conditions.
Peter Eisentraut [Thu, 13 Aug 2009 20:50:05 +0000 (20:50 +0000)]
Augment test coverage in PL/Python, especially for error conditions.

16 years agoAdd a simple test case covering a join against an inheritance tree,
Tom Lane [Thu, 13 Aug 2009 17:14:38 +0000 (17:14 +0000)]
Add a simple test case covering a join against an inheritance tree,
since we're evidently not testing that at all right now :-(

16 years agoPut back adjust_appendrel_attrs()'s code for dealing with RestrictInfo.
Tom Lane [Thu, 13 Aug 2009 16:53:09 +0000 (16:53 +0000)]
Put back adjust_appendrel_attrs()'s code for dealing with RestrictInfo.
I mistakenly removed it last month, thinking it was no longer needed ---
but it is still needed for dealing with joininfo lists.  Fortunately this
bit of brain fade hadn't made it into any released versions yet.

16 years agoImprove error message for the case where a requested foreign key constraint
Tom Lane [Wed, 12 Aug 2009 23:00:12 +0000 (23:00 +0000)]
Improve error message for the case where a requested foreign key constraint
does match some unique index on the referenced table, but that index is
only deferrably unique.  We were doing this nicely for the
default-to-primary-key case, but were being lazy for the other case.

Dean Rasheed

16 years agoThe html-stamp and man-stamp files also need to be cvsignore'd.
Tom Lane [Wed, 12 Aug 2009 21:03:52 +0000 (21:03 +0000)]
The html-stamp and man-stamp files also need to be cvsignore'd.

16 years agoAllow backends to start up without use of the flat-file copy of pg_database.
Tom Lane [Wed, 12 Aug 2009 20:53:31 +0000 (20:53 +0000)]
Allow backends to start up without use of the flat-file copy of pg_database.

To make this work in the base case, pg_database now has a nailed-in-cache
relation descriptor that is initialized using hardwired knowledge in
relcache.c.  This means pg_database is added to the set of relations that
need to have a Schema_pg_xxx macro maintained in pg_attribute.h.  When this
path is taken, we'll have to do a seqscan of pg_database to find the row
we need.

In the normal case, we are able to do an indexscan to find the database's row
by name.  This is made possible by storing a global relcache init file that
describes only the shared catalogs and their indexes (and therefore is usable
by all backends in any database).  A new backend loads this cache file,
finds its database OID after an indexscan on pg_database, and then loads
the local relcache init file for that database.

This change should effectively eliminate number of databases as a factor
in backend startup time, even with large numbers of databases.  However,
the real reason for doing it is as a first step towards getting rid of
the flat files altogether.  There are still several other sub-projects
to be tackled before that can happen.

16 years agoFix old bug in log_autovacuum_min_duration code: it was relying on being able