From: Bruce Momjian Date: Sun, 13 Dec 1998 02:50:39 +0000 (+0000) Subject: This patch fixes the undefined (according to C) and erroneous (under X-Git-Url: http://waps.l3s.uni-hannover.de/gitweb/queryCache.php?a=commitdiff_plain;h=b9d3fce0d1a07905fb84bd31dd22ca8e71cb2388;p=users%2Fbernd%2Fpostgres.git This patch fixes the undefined (according to C) and erroneous (under Digital Uni x with both DEC cc and gcc) behaviour of modifying an lvalue on the left side an d then using it on the right side of an assignment. Since this code modifies the dbname parameter, it was changing, for example, "dbname=template1" into "dbname =emplate1". David Smith Programmer P --- diff --git a/src/interfaces/perl5/Pg.xs b/src/interfaces/perl5/Pg.xs index d4697a9a32..66c322d843 100644 --- a/src/interfaces/perl5/Pg.xs +++ b/src/interfaces/perl5/Pg.xs @@ -215,7 +215,8 @@ PQconnectdb(conninfo) } } else { while (*ptr && *ptr != ' ' && *ptr != '\t') { - *ptr++ = tolower(*ptr); + *ptr = tolower(*ptr); + ptr++; } } } @@ -732,7 +733,8 @@ connectdb(conninfo) } } else { while (*ptr && *ptr != ' ' && *ptr != '\t') { - *ptr++ = tolower(*ptr); + *ptr = tolower(*ptr); + ptr++; } } }