From: Marko Kreen <markokr@gmail.com>
Date: Thu, 18 Oct 2007 12:19:11 +0000 (+0000)
Subject: sanity check before trying to set parameters
X-Git-Tag: pgbouncer_1_1_1~4
X-Git-Url: http://waps.l3s.uni-hannover.de/gitweb/queryCache.php?a=commitdiff_plain;h=6cc248029c495f67e43aef1c989eb9559ad57bb5;p=pgbouncer.git

sanity check before trying to set parameters
---

diff --git a/src/varcache.c b/src/varcache.c
index 7ba2175..acf6001 100644
--- a/src/varcache.c
+++ b/src/varcache.c
@@ -106,10 +106,19 @@ static int apply_var(PktBuf *pkt, const char *key,
 	if (strcasecmp(cval, sval) == 0)
 		return 0;
 
+	/* sanity check */
+	if (!*cval || !*sval) {
+		/* parameters that can change should be always set */
+		log_warning("Parameter unset: key='%s' client='%s' server='%s'",
+			    key, cval, sval);
+		return 0;
+	}
+
 	/* the string may have been taken from startup pkt */
 	if (!quote_literal(qbuf, sizeof(qbuf), cval, std_quote))
 		return 0;
 
+	/* add SET statement to packet */
 	len = snprintf(buf, sizeof(buf), "SET %s=%s;", key, qbuf);
 	if (len < sizeof(buf)) {
 		pktbuf_put_bytes(pkt, buf, len);