From e5ec21bcf554d1c70bf5cbc07757944f5b3251f4 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Fri, 7 May 2004 03:20:01 +0000 Subject: [PATCH] NATURAL CROSS JOIN is a contradiction in terms, not to mention disallowed by the SQL spec and by our parser. Thanks to Jonathan Scott for finding this longstanding error. --- src/backend/utils/adt/ruleutils.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/backend/utils/adt/ruleutils.c b/src/backend/utils/adt/ruleutils.c index 5de2c2a63f..7b6b20509b 100644 --- a/src/backend/utils/adt/ruleutils.c +++ b/src/backend/utils/adt/ruleutils.c @@ -3830,14 +3830,9 @@ get_from_clause_item(Node *jtnode, Query *query, deparse_context *context) switch (j->jointype) { case JOIN_INNER: - if (j->quals) - appendContextKeyword(context, "NATURAL JOIN ", - -PRETTYINDENT_JOIN, - PRETTYINDENT_JOIN, 0); - else - appendContextKeyword(context, "NATURAL CROSS JOIN ", - -PRETTYINDENT_JOIN, - PRETTYINDENT_JOIN, 0); + appendContextKeyword(context, "NATURAL JOIN ", + -PRETTYINDENT_JOIN, + PRETTYINDENT_JOIN, 0); break; case JOIN_LEFT: appendContextKeyword(context, "NATURAL LEFT JOIN ", -- 2.39.5