From 9d7b9519b9fc718973cccb24c439affc92df7736 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sat, 22 Sep 2007 04:41:19 +0000 Subject: [PATCH] Parenthesize macro arguments safely. I see no bug among the current uses of PG_DETOAST_DATUM_SLICE, but it's clearly trouble waiting to happen. --- src/include/fmgr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/include/fmgr.h b/src/include/fmgr.h index a231626478..a57439ee25 100644 --- a/src/include/fmgr.h +++ b/src/include/fmgr.h @@ -179,7 +179,7 @@ extern struct varlena *pg_detoast_datum_packed(struct varlena * datum); pg_detoast_datum_copy((struct varlena *) DatumGetPointer(datum)) #define PG_DETOAST_DATUM_SLICE(datum,f,c) \ pg_detoast_datum_slice((struct varlena *) DatumGetPointer(datum), \ - (int32) f, (int32) c) + (int32) (f), (int32) (c)) /* WARNING -- unaligned pointer */ #define PG_DETOAST_DATUM_PACKED(datum) \ pg_detoast_datum_packed((struct varlena *) DatumGetPointer(datum)) -- 2.39.5