From 79f444664927d4d80854a1dd7b7ad8cf6d9ee1b2 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sun, 30 Jul 2006 20:17:11 +0000 Subject: [PATCH] Fix a couple of comments. --- src/backend/storage/ipc/procarray.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/backend/storage/ipc/procarray.c b/src/backend/storage/ipc/procarray.c index 1f24fdc5a0..02d2ded553 100644 --- a/src/backend/storage/ipc/procarray.c +++ b/src/backend/storage/ipc/procarray.c @@ -446,10 +446,8 @@ GetOldestXmin(bool allDbs, bool ignoreVacuum) /* * Also consider the transaction's Xmin, if set. * - * Note that this Xmin may seem to be guaranteed to be always - * lower than the transaction's Xid, but this is not so because - * there is a time window on which the Xid is already assigned - * but the Xmin has not being calculated yet. + * We must check both Xid and Xmin because there is a window + * where an xact's Xid is set but Xmin isn't yet. */ xid = proc->xmin; if (TransactionIdIsNormal(xid)) @@ -489,7 +487,7 @@ GetOldestXmin(bool allDbs, bool ignoreVacuum) * older than this are known not running any more. * RecentGlobalXmin: the global xmin (oldest TransactionXmin across all * running transactions, except those running LAZY VACUUM). This is - * the same computation done by GetOldestXmin(true, false). + * the same computation done by GetOldestXmin(true, true). *---------- */ Snapshot -- 2.39.5