From 79edf770bc984a6007200fde9be778b68e41c86c Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Tue, 16 Sep 2008 00:49:49 +0000 Subject: [PATCH] Fix multiple memory leaks in xml_out(). Per report from Matt Magoffin. --- src/backend/utils/adt/xml.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/backend/utils/adt/xml.c b/src/backend/utils/adt/xml.c index ca2c4a149e..69f515a3b2 100644 --- a/src/backend/utils/adt/xml.c +++ b/src/backend/utils/adt/xml.c @@ -208,7 +208,6 @@ xml_out_internal(xmltype *x, pg_enc target_encoding) #ifdef USE_LIBXML xmlChar *version; - xmlChar *encoding; int standalone; int res_code; #endif @@ -220,7 +219,7 @@ xml_out_internal(xmltype *x, pg_enc target_encoding) #ifdef USE_LIBXML if ((res_code = parse_xml_decl((xmlChar *) str, - &len, &version, &encoding, &standalone)) == 0) + &len, &version, NULL, &standalone)) == 0) { StringInfoData buf; @@ -238,6 +237,10 @@ xml_out_internal(xmltype *x, pg_enc target_encoding) } appendStringInfoString(&buf, str + len); + if (version) + xmlFree(version); + pfree(str); + return buf.data; } -- 2.39.5