Tom Lane [Sun, 29 May 2005 17:11:07 +0000 (17:11 +0000)]
expandRTE and get_rte_attribute_type mistakenly always imputed typmod -1
to columns of an RTE that was a function returning RECORD with a column
definition list. Apparently no one has tried to use non-default typmod
with a function returning RECORD before.
Tom Lane [Sun, 29 May 2005 04:23:07 +0000 (04:23 +0000)]
Modify hash_search() API to prevent future occurrences of the error
spotted by Qingqing Zhou. The HASH_ENTER action now automatically
fails with elog(ERROR) on out-of-memory --- which incidentally lets
us eliminate duplicate error checks in quite a bunch of places. If
you really need the old return-NULL-on-out-of-memory behavior, you
can ask for HASH_ENTER_NULL. But there is now an Assert in that path
checking that you aren't hoping to get that behavior in a palloc-based
hash table.
Along the way, remove the old HASH_FIND_SAVE/HASH_REMOVE_SAVED actions,
which were not being used anywhere anymore, and were surely too ugly
and unsafe to want to see revived again.
Bruce Momjian [Sun, 29 May 2005 03:32:18 +0000 (03:32 +0000)]
Add reference to libpq environment variables for client applications.
Tom Lane [Sat, 28 May 2005 17:21:32 +0000 (17:21 +0000)]
Bgwriter should PANIC if it runs out of memory for pending-fsyncs
hash table. This is a pretty unlikely scenario, since the table
should be tiny, but we can't guarantee continued correct operation
if it does occur. Spotted by Qingqing Zhou.
Tom Lane [Sat, 28 May 2005 05:10:47 +0000 (05:10 +0000)]
get_expr_result_type has to be prepared to pull type information
from a RECORD Const node, because that's what it may be faced with
after constant-folding of a function returning RECORD. Per example
from Michael Fuhr.
Bruce Momjian [Sat, 28 May 2005 04:12:13 +0000 (04:12 +0000)]
Remove:
<
< * Add XML output to pg_dump and COPY
<
< We already allow XML to be stored in the database, and XPath queries
< can be used on that data using /contrib/xml2. It also supports XSLT
< transformations.
Tom Lane [Fri, 27 May 2005 23:31:21 +0000 (23:31 +0000)]
Arrange to cache fmgr lookup information for an index's access method
routines in the index's relcache entry, instead of doing a fresh fmgr_info
on every index access. We were already doing this for the index's opclass
support functions; not sure why we didn't think to do it for the AM
functions too. This supersedes the former method of caching (only)
amgettuple in indexscan scan descriptors; it's an improvement because the
function lookup can be amortized across multiple statements instead of
being repeated for each statement. Even though lookup for builtin
functions is pretty cheap, this seems to drop a percent or two off some
simple benchmarks.
Bruce Momjian [Fri, 27 May 2005 22:10:20 +0000 (22:10 +0000)]
Update Farsi FAQ.
Mahmoud Taghizadeh