From: Tom Lane Date: Mon, 14 Jul 2008 03:22:32 +0000 (+0000) Subject: Clean up buildfarm failures arising from the seemingly straightforward page X-Git-Tag: recoveryinfrav9~833 X-Git-Url: http://waps.l3s.uni-hannover.de/gitweb/?a=commitdiff_plain;h=501483d73cebc3fac609bc7aa86e33b3237a2b3c;p=users%2Fsimon%2Fpostgres.git Clean up buildfarm failures arising from the seemingly straightforward page macros patch :-(. Results from both baiji and mastodon imply that MSVC fails to perceive offsetof(PageHeaderData, pd_linp[0]) as a constant expression in some contexts where offsetof(PageHeaderData, pd_linp) works fine. Sloth, thy name is Micro. --- diff --git a/src/include/storage/bufpage.h b/src/include/storage/bufpage.h index 5a7fd1bdd1..e60ffca76c 100644 --- a/src/include/storage/bufpage.h +++ b/src/include/storage/bufpage.h @@ -179,9 +179,9 @@ typedef PageHeaderData *PageHeader; #define PageIsValid(page) PointerIsValid(page) /* - * line pointer does not count as part of header + * line pointer(s) do not count as part of header */ -#define SizeOfPageHeaderData (offsetof(PageHeaderData, pd_linp[0])) +#define SizeOfPageHeaderData (offsetof(PageHeaderData, pd_linp)) /* * PageIsEmpty