From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Tue, 2 Nov 2010 21:31:54 +0000 (-0400)
Subject: Fix buffer overrun in pg_upgrade.
X-Git-Url: http://waps.l3s.uni-hannover.de/gitweb/?a=commitdiff_plain;h=368e44f6a54a81d036fb85ea0f4544a233d7cf11;p=users%2Fhanada%2Fpostgres.git

Fix buffer overrun in pg_upgrade.

Problem reported, and cause identified, by Hernan Gonzalez.
---

diff --git a/contrib/pg_upgrade/controldata.c b/contrib/pg_upgrade/controldata.c
index 009a1cc098..dd805a42ac 100644
--- a/contrib/pg_upgrade/controldata.c
+++ b/contrib/pg_upgrade/controldata.c
@@ -545,7 +545,7 @@ putenv2(migratorContext *ctx, const char *var, const char *val)
 	{
 #ifndef WIN32
 		char	   *envstr = (char *) pg_malloc(ctx, strlen(var) +
-												strlen(val) + 1);
+												strlen(val) + 2);
 
 		sprintf(envstr, "%s=%s", var, val);
 		putenv(envstr);