From: Magnus Hagander <magnus@hagander.net>
Date: Mon, 2 Jun 2025 09:57:20 +0000 (+0200)
Subject: Give error message instead of empty list for no permissions
X-Git-Url: http://waps.l3s.uni-hannover.de/gitweb/?a=commitdiff_plain;h=3268fcef55a7692dd140337a939bf0c36bc89d3f;p=pgmailmgr.git

Give error message instead of empty list for no permissions
---

diff --git a/pgmailmgr/mailmgr/templates/noadm.html b/pgmailmgr/mailmgr/templates/noadm.html
new file mode 100644
index 0000000..9c85ba9
--- /dev/null
+++ b/pgmailmgr/mailmgr/templates/noadm.html
@@ -0,0 +1,8 @@
+{%extends "base.html" %}
+
+{%block content%}
+<h1>Permission denied</h1>
+<p>
+  You don't have access to manage any users or forwarders.
+</p>
+{%endblock%}
diff --git a/pgmailmgr/mailmgr/views.py b/pgmailmgr/mailmgr/views.py
index 7e1c584..41b6df6 100644
--- a/pgmailmgr/mailmgr/views.py
+++ b/pgmailmgr/mailmgr/views.py
@@ -26,6 +26,10 @@ def adm_home(request):
     users = VirtualUser.objects.extra(where=["EXISTS (SELECT 1 FROM mailmgr_userpermissions p WHERE p.user_id=%s AND p.domain_id = local_domain_id AND local_part ~* ('^'||p.pattern||'$'))" % request.user.id])
     forwards = Forwarder.objects.extra(where=["EXISTS (SELECT 1 FROM mailmgr_userpermissions p WHERE p.user_id=%s AND p.domain_id = local_domain_id AND local_part ~* ('^'||p.pattern||'$'))" % request.user.id])
 
+    if not forwards and not users:
+        return render(request, 'noadm.html', {
+        })
+
     return render(request, 'adm.html', {
         'users': users,
         'forwarders': forwards,