From: Tom Lane Date: Fri, 5 Jun 2009 18:50:47 +0000 (+0000) Subject: GIN's ItemPointerIsMin, ItemPointerIsMax, and ItemPointerIsLossyPage macros X-Git-Url: http://waps.l3s.uni-hannover.de/gitweb/?a=commitdiff_plain;h=0e21a7d74ba4f519fe27842ad14c002580faa0d9;p=users%2Fsimon%2Fpostgres.git GIN's ItemPointerIsMin, ItemPointerIsMax, and ItemPointerIsLossyPage macros should use GinItemPointerGetBlockNumber/GinItemPointerGetOffsetNumber, not ItemPointerGetBlockNumber/ItemPointerGetOffsetNumber, because the latter will Assert() on ip_posid == 0, ie a "Min" pointer. (Thus, ItemPointerIsMin has never worked at all, but it seems unused at present.) I'm not certain that the case can occur in normal functioning, but it's blowing up on me while investigating Tatsuo-san's data corruption problem. In any case it seems like a problem waiting to bite someone. Back-patch just in case this really is a problem for somebody in the field. --- diff --git a/src/include/access/gin.h b/src/include/access/gin.h index 95cef21b46..44510a36a5 100644 --- a/src/include/access/gin.h +++ b/src/include/access/gin.h @@ -124,18 +124,18 @@ typedef struct GinMetaPageData #define ItemPointerSetMin(p) \ ItemPointerSet((p), (BlockNumber)0, (OffsetNumber)0) #define ItemPointerIsMin(p) \ - (ItemPointerGetOffsetNumber(p) == (OffsetNumber)0 && \ - ItemPointerGetBlockNumber(p) == (BlockNumber)0) + (GinItemPointerGetOffsetNumber(p) == (OffsetNumber)0 && \ + GinItemPointerGetBlockNumber(p) == (BlockNumber)0) #define ItemPointerSetMax(p) \ ItemPointerSet((p), InvalidBlockNumber, (OffsetNumber)0xffff) #define ItemPointerIsMax(p) \ - (ItemPointerGetOffsetNumber(p) == (OffsetNumber)0xffff && \ - ItemPointerGetBlockNumber(p) == InvalidBlockNumber) + (GinItemPointerGetOffsetNumber(p) == (OffsetNumber)0xffff && \ + GinItemPointerGetBlockNumber(p) == InvalidBlockNumber) #define ItemPointerSetLossyPage(p, b) \ ItemPointerSet((p), (b), (OffsetNumber)0xffff) #define ItemPointerIsLossyPage(p) \ - (ItemPointerGetOffsetNumber(p) == (OffsetNumber)0xffff && \ - ItemPointerGetBlockNumber(p) != InvalidBlockNumber) + (GinItemPointerGetOffsetNumber(p) == (OffsetNumber)0xffff && \ + GinItemPointerGetBlockNumber(p) != InvalidBlockNumber) typedef struct {