From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Tue, 15 Jan 2002 22:33:20 +0000 (+0000)
Subject: If we fail to rename pg_internal.init into place, delete the useless
X-Git-Url: http://waps.l3s.uni-hannover.de/gitweb/?a=commitdiff_plain;h=0358be81dc296e2effc8557175d83be4bc71b974;p=users%2Fbernd%2Fpostgres.git

If we fail to rename pg_internal.init into place, delete the useless
temporary file.  This seems to be a known failure mode under Cygwin,
so we might as well expend the extra line of code to be tidy.
---

diff --git a/src/backend/utils/cache/relcache.c b/src/backend/utils/cache/relcache.c
index 4f6c571355..7cb561a3ff 100644
--- a/src/backend/utils/cache/relcache.c
+++ b/src/backend/utils/cache/relcache.c
@@ -2978,5 +2978,12 @@ write_irels(void)
 	 * previously-existing init file.
 	 */
 	if (rename(tempfilename, finalfilename) < 0)
+	{
 		elog(NOTICE, "Cannot rename init file %s to %s: %m\n\tContinuing anyway, but there's something wrong.", tempfilename, finalfilename);
+		/*
+		 * If we fail, try to clean up the useless temp file; don't bother
+		 * to complain if this fails too.
+		 */
+		unlink(tempfilename);
+	}
 }