Clean up rather sloppy fix in HEAD for the ancient bug that CREATE CONVERSION

didn't create a dependency from the new conversion to its schema.  Back-patch
to all supported releases.

diff --git a/src/backend/catalog/pg_conversion.c b/src/backend/catalog/pg_conversion.c
index 3941748e681997d6cfcb157866349714378e417f..a46be475e359d13e1126c370ea889fe86ac21c31 100644 (file)
--- a/src/backend/catalog/pg_conversion.c
+++ b/src/backend/catalog/pg_conversion.c
@@ -18,6 +18,7 @@
 #include "catalog/dependency.h"
 #include "catalog/indexing.h"
 #include "catalog/pg_conversion.h"
+#include "catalog/pg_namespace.h"
 #include "catalog/pg_proc.h"
 #include "catalog/namespace.h"
 #include "utils/builtins.h"
@@ -120,6 +121,12 @@ ConversionCreate(const char *conname, Oid connamespace,
        referenced.objectSubId = 0;
        recordDependencyOn(&myself, &referenced, DEPENDENCY_NORMAL);
 
+       /* create dependency on namespace */
+       referenced.classId = NamespaceRelationId;
+       referenced.objectId = connamespace;
+       referenced.objectSubId = 0;
+       recordDependencyOn(&myself, &referenced, DEPENDENCY_NORMAL);
+
        /* create dependency on owner */
        recordDependencyOnOwner(ConversionRelationId, HeapTupleGetOid(tup),
                                                        conowner);