Use SYSTEMQUOTE as concatentation to strings, rather than %s printf

patterns, for clarity.

diff --git a/src/backend/postmaster/postmaster.c b/src/backend/postmaster/postmaster.c
index 4426a07dd9b994cd4b6e8f8c1003df2158325361..eeaba2e226eef090945fe3e286493a346de7a267 100644 (file)
--- a/src/backend/postmaster/postmaster.c
+++ b/src/backend/postmaster/postmaster.c
@@ -4184,7 +4184,7 @@ CreateOptsFile(int argc, char *argv[], char *fullprogname)
 
        fprintf(fp, "%s", fullprogname);
        for (i = 1; i < argc; i++)
-               fprintf(fp, " %s%s%s", SYSTEMQUOTE, argv[i], SYSTEMQUOTE);
+               fprintf(fp, " " SYSTEMQUOTE "%s" SYSTEMQUOTE, argv[i]);
        fputs("\n", fp);
 
        if (fclose(fp))

diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c
index aff81b452eb6f46790f69d3418afa09ba2553348..cb5d8dd23461f9438898f84b5fe4e01f6a9db6b7 100644 (file)
--- a/src/bin/initdb/initdb.c
+++ b/src/bin/initdb/initdb.c
@@ -1078,14 +1078,14 @@ test_config_settings(void)
                test_max_fsm = FSM_FOR_BUFS(test_buffs);
 
                snprintf(cmd, sizeof(cmd),
-                                "%s\"%s\" --boot -x0 %s "
+                                SYSTEMQUOTE "\"%s\" --boot -x0 %s "
                                 "-c max_connections=%d "
                                 "-c shared_buffers=%d "
                                 "-c max_fsm_pages=%d "
-                                "< \"%s\" > \"%s\" 2>&1%s",
-                                SYSTEMQUOTE, backend_exec, boot_options,
+                                "< \"%s\" > \"%s\" 2>&1" SYSTEMQUOTE,
+                                backend_exec, boot_options,
                                 test_conns, test_buffs, test_max_fsm,
-                                DEVNULL, DEVNULL, SYSTEMQUOTE);
+                                DEVNULL, DEVNULL);
                status = system(cmd);
                if (status == 0)
                {
@@ -1114,14 +1114,14 @@ test_config_settings(void)
                test_max_fsm = FSM_FOR_BUFS(test_buffs);
 
                snprintf(cmd, sizeof(cmd),
-                                "%s\"%s\" --boot -x0 %s "
+                                SYSTEMQUOTE "\"%s\" --boot -x0 %s "
                                 "-c max_connections=%d "
                                 "-c shared_buffers=%d "
                                 "-c max_fsm_pages=%d "
-                                "< \"%s\" > \"%s\" 2>&1%s",
-                                SYSTEMQUOTE, backend_exec, boot_options,
+                                "< \"%s\" > \"%s\" 2>&1" SYSTEMQUOTE,
+                                backend_exec, boot_options,
                                 n_connections, test_buffs, test_max_fsm,
-                                DEVNULL, DEVNULL, SYSTEMQUOTE);
+                                DEVNULL, DEVNULL);
                status = system(cmd);
                if (status == 0)
                        break;

diff --git a/src/bin/pg_ctl/pg_ctl.c b/src/bin/pg_ctl/pg_ctl.c
index 5c96372af878b30d53325b7e21cf37a72ab4715f..424c47b10ffb5daaa02788686be1eeaa51182224 100644 (file)
--- a/src/bin/pg_ctl/pg_ctl.c
+++ b/src/bin/pg_ctl/pg_ctl.c
@@ -361,13 +361,12 @@ start_postmaster(void)
         * everything to a shell to process them.
         */
        if (log_file != NULL)
-               snprintf(cmd, MAXPGPATH, "%s\"%s\" %s%s < \"%s\" >> \"%s\" 2>&1 &%s",
-                                SYSTEMQUOTE, postgres_path, pgdata_opt, post_opts,
-                                DEVNULL, log_file, SYSTEMQUOTE);
+               snprintf(cmd, MAXPGPATH, SYSTEMQUOTE "\"%s\" %s%s < \"%s\" >> \"%s\" 2>&1 &" SYSTEMQUOTE,
+                                postgres_path, pgdata_opt, post_opts,
+                                DEVNULL, log_file);
        else
-               snprintf(cmd, MAXPGPATH, "%s\"%s\" %s%s < \"%s\" 2>&1 &%s",
-                                SYSTEMQUOTE, postgres_path, pgdata_opt, post_opts,
-                                DEVNULL, SYSTEMQUOTE);
+               snprintf(cmd, MAXPGPATH, SYSTEMQUOTE "\"%s\" %s%s < \"%s\" 2>&1 &" SYSTEMQUOTE,
+                                postgres_path, pgdata_opt, post_opts, DEVNULL);
 
        return system(cmd);
 #else                                                  /* WIN32 */
@@ -380,13 +379,11 @@ start_postmaster(void)
        PROCESS_INFORMATION pi;
 
        if (log_file != NULL)
-               snprintf(cmd, MAXPGPATH, "CMD /C %s\"%s\" %s%s < \"%s\" >> \"%s\" 2>&1%s",
-                                SYSTEMQUOTE, postgres_path, pgdata_opt, post_opts,
-                                DEVNULL, log_file, SYSTEMQUOTE);
+               snprintf(cmd, MAXPGPATH, "CMD /C " SYSTEMQUOTE "\"%s\" %s%s < \"%s\" >> \"%s\" 2>&1" SYSTEMQUOTE,
+                                postgres_path, pgdata_opt, post_opts, DEVNULL, log_file);
        else
-               snprintf(cmd, MAXPGPATH, "CMD /C %s\"%s\" %s%s < \"%s\" 2>&1%s",
-                                SYSTEMQUOTE, postgres_path, pgdata_opt, post_opts,
-                                DEVNULL, SYSTEMQUOTE);
+               snprintf(cmd, MAXPGPATH, "CMD /C " SYSTEMQUOTE "\"%s\" %s%s < \"%s\" 2>&1" SYSTEMQUOTE,
+                                postgres_path, pgdata_opt, post_opts, DEVNULL);
 
        if (!CreateRestrictedProcess(cmd, &pi))
                return GetLastError();

diff --git a/src/bin/pg_dump/pg_dumpall.c b/src/bin/pg_dump/pg_dumpall.c
index beacebd077c10958a155add348e824d6f0bb3107..93597a70593026cc115b838dc68ed66b9a3bc88e 100644 (file)
--- a/src/bin/pg_dump/pg_dumpall.c
+++ b/src/bin/pg_dump/pg_dumpall.c
@@ -1248,18 +1248,18 @@ runPgDump(const char *dbname)
        if (filename)
        {
 #ifndef WIN32
-               appendPQExpBuffer(cmd, "%s\"%s\" %s -Fa '", SYSTEMQUOTE, pg_dump_bin,
+               appendPQExpBuffer(cmd, SYSTEMQUOTE"\"%s\" %s -Fa '", pg_dump_bin,
 #else
-               appendPQExpBuffer(cmd, "%s\"%s\" %s -Fa \"", SYSTEMQUOTE, pg_dump_bin,
+               appendPQExpBuffer(cmd, SYSTEMQUOTE"\"%s\" %s -Fa \"", pg_dump_bin,
 #endif
                                                  pgdumpopts->data);
        }
        else
        {
 #ifndef WIN32
-               appendPQExpBuffer(cmd, "%s\"%s\" %s -Fp '", SYSTEMQUOTE, pg_dump_bin,
+               appendPQExpBuffer(cmd, SYSTEMQUOTE "\"%s\" %s -Fp '", pg_dump_bin,
 #else
-               appendPQExpBuffer(cmd, "%s\"%s\" %s -Fp \"", SYSTEMQUOTE, pg_dump_bin,
+               appendPQExpBuffer(cmd, SYSTEMQUOTE "\"%s\" %s -Fp \"", pg_dump_bin,
 #endif
                                                  pgdumpopts->data);
        }

diff --git a/src/bin/psql/command.c b/src/bin/psql/command.c
index dfd0f942e96c587b57533c5983983e7a235a5891..559791593e45b47cb15ef58a3feb8d1842180ada 100644 (file)
--- a/src/bin/psql/command.c
+++ b/src/bin/psql/command.c
@@ -1288,8 +1288,7 @@ editFile(const char *fname)
 #ifndef WIN32
        sprintf(sys, "exec %s '%s'", editorName, fname);
 #else
-       sprintf(sys, "%s\"%s\" \"%s\"%s",
-                       SYSTEMQUOTE, editorName, fname, SYSTEMQUOTE);
+       sprintf(sys, SYSTEMQUOTE "\"%s\" \"%s\"" SYSTEMQUOTE, editorName, fname);
 #endif
        result = system(sys);
        if (result == -1)
@@ -1790,9 +1789,8 @@ do_shell(const char *command)
                /* See EDITOR handling comment for an explaination */
                                "exec %s", shellName);
 #else
-               sprintf(sys,
                /* See EDITOR handling comment for an explaination */
-                               "%s\"%s\"%s", SYSTEMQUOTE, shellName, SYSTEMQUOTE);
+               sprintf(sys, SYSTEMQUOTE "\"%s\"" SYSTEMQUOTE, shellName);
 #endif
                result = system(sys);
                free(sys);