Add missing reset of need_initialization in reloptions code.

This resulted in useless extra work during every call of parseRelOptions,
but no bad effects other than that.  Noted by Alvaro.

diff --git a/src/backend/access/common/reloptions.c b/src/backend/access/common/reloptions.c
index e1ce8596132266e6ce9feda640eeecee29b9bb1b..83c41b3da41a2e39ed40110b54ef90c5ead1b496 100644 (file)
--- a/src/backend/access/common/reloptions.c
+++ b/src/backend/access/common/reloptions.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *   $PostgreSQL: pgsql/src/backend/access/common/reloptions.c,v 1.28.2.1 2009/08/27 17:19:31 alvherre Exp $
+ *   $PostgreSQL: pgsql/src/backend/access/common/reloptions.c,v 1.28.2.2 2010/03/11 21:47:25 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -210,8 +210,9 @@ static void
 initialize_reloptions(void)
 {
    int         i;
-   int         j = 0;
+   int         j;
 
+   j = 0;
    for (i = 0; boolRelOpts[i].gen.name; i++)
        j++;
    for (i = 0; intRelOpts[i].gen.name; i++)
@@ -268,6 +269,9 @@ initialize_reloptions(void)
 
    /* add a list terminator */
    relOpts[j] = NULL;
+
+   /* flag the work is complete */
+   need_initialization = false;
 }
 
 /*