Fix outfuncs.c to dump A_Const nodes representing NULLs correctly. This has

been broken since forever, but was not noticed because people seldom look
at raw parse trees.  AFAIK, no impact on users except that debug_print_parse
might fail; but patch it all the way back anyway.  Per report from Jeff Ross.

diff --git a/src/backend/nodes/outfuncs.c b/src/backend/nodes/outfuncs.c
index 4a494299fca7e9d9824886478bcd5746fd01766e..b6ce20fea77c79652b511327df930fc88218ca92 100644 (file)
--- a/src/backend/nodes/outfuncs.c
+++ b/src/backend/nodes/outfuncs.c
@@ -1407,6 +1407,10 @@ _outValue(StringInfo str, Value *value)
                        /* internal representation already has leading 'b' */
                        appendStringInfo(str, "%s", value->val.str);
                        break;
+               case T_Null:
+                       /* this is seen only within A_Const, not in transformed trees */
+                       appendStringInfoString(str, "NULL");
+                       break;
                default:
                        elog(ERROR, "unrecognized node type: %d", (int) value->type);
                        break;
@@ -1435,8 +1439,9 @@ _outParamRef(StringInfo str, ParamRef *node)
 static void
 _outAConst(StringInfo str, A_Const *node)
 {
-       WRITE_NODE_TYPE("CONST ");
+       WRITE_NODE_TYPE("A_CONST");
 
+       appendStringInfo(str, " :val ");
        _outValue(str, &(node->val));
        WRITE_NODE_FIELD(typename);
 }