Add comment on why pg *printf functions are used unconditionally on

Win32.

Backpatch to 8.1.X.

diff --git a/configure b/configure
index 26233f1e1c39b75070ca73e38c53fcb9dc3406ba..2fdc17b1cbf4d7618a817742e21de0089c958f4b 100755 (executable)
--- a/configure
+++ b/configure
@@ -13854,6 +13854,10 @@ fi
 
 if test "$PORTNAME" = "win32"; then
   # Win32 gets this built unconditionally
+  # libintl versions prior to 0.13 use the native *printf functions.
+  # Win32 *printf does not understand %$, so on Win32 using pre-0.13 libintl
+  # it is necessary to use the pg versions of *printf to properly process
+  # NLS strings that use the %$ format.
   pgac_need_repl_snprintf=yes
 else
   pgac_need_repl_snprintf=no

diff --git a/configure.in b/configure.in
index 96625562ff3c1dfd7c76f3aafa79d1d078d58088..e01a257cea1b4d64984490b84c659e7ae0e0b024 100644 (file)
--- a/configure.in
+++ b/configure.in
@@ -852,6 +852,10 @@ fi
 
 if test "$PORTNAME" = "win32"; then
   # Win32 gets this built unconditionally
+  # libintl versions prior to 0.13 use the native *printf functions.
+  # Win32 *printf does not understand %$, so on Win32 using pre-0.13 libintl
+  # it is necessary to use the pg versions of *printf to properly process
+  # NLS strings that use the %$ format.
   pgac_need_repl_snprintf=yes
 else
   pgac_need_repl_snprintf=no