Fix plpgsql's exec_eval_expr() to ensure it returns a sane type OID

even when the expression is a query that returns no rows.

So far as I can tell, the only caller that actually fails when a garbage
OID is returned is exec_stmt_case(), which is new in 8.4 --- in all other
cases, we might make a useless trip through casting logic, but we won't
fail since the isnull flag will be set.  Hence, backpatch only to 8.4,
just in case there are apps out there that aren't expecting an error to
be thrown if the query returns more or less than one column.  (Which seems
unlikely, since the error would be thrown if the query ever did return a
row; but it's possible there's some never-exercised code out there.)

Per report from Mario Splivalo.

diff --git a/src/pl/plpgsql/src/pl_exec.c b/src/pl/plpgsql/src/pl_exec.c
index 899860a62f70a772e50ad56df6d895aabc27cba0..8f5e97b240f02a0cfc9d19a2426daafdcc6dd7d4 100644 (file)
--- a/src/pl/plpgsql/src/pl_exec.c
+++ b/src/pl/plpgsql/src/pl_exec.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *   $PostgreSQL: pgsql/src/pl/plpgsql/src/pl_exec.c,v 1.244.2.3 2010/02/12 19:37:43 tgl Exp $
+ *   $PostgreSQL: pgsql/src/pl/plpgsql/src/pl_exec.c,v 1.244.2.4 2010/04/14 23:52:16 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -4082,7 +4082,24 @@ exec_eval_expr(PLpgSQL_execstate *estate,
                 errmsg("query \"%s\" did not return data", expr->query)));
 
    /*
-    * If there are no rows selected, the result is NULL.
+    * Check that the expression returns exactly one column...
+    */
+   if (estate->eval_tuptable->tupdesc->natts != 1)
+       ereport(ERROR,
+               (errcode(ERRCODE_SYNTAX_ERROR),
+                errmsg_plural("query \"%s\" returned %d column",
+                              "query \"%s\" returned %d columns",
+                              estate->eval_tuptable->tupdesc->natts,
+                              expr->query,
+                              estate->eval_tuptable->tupdesc->natts)));
+
+   /*
+    * ... and get the column's datatype.
+    */
+   *rettype = SPI_gettypeid(estate->eval_tuptable->tupdesc, 1);
+
+   /*
+    * If there are no rows selected, the result is a NULL of that type.
     */
    if (estate->eval_processed == 0)
    {
@@ -4091,26 +4108,17 @@ exec_eval_expr(PLpgSQL_execstate *estate,
    }
 
    /*
-    * Check that the expression returned one single Datum
+    * Check that the expression returned no more than one row.
     */
-   if (estate->eval_processed > 1)
+   if (estate->eval_processed != 1)
        ereport(ERROR,
                (errcode(ERRCODE_CARDINALITY_VIOLATION),
                 errmsg("query \"%s\" returned more than one row",
                        expr->query)));
-   if (estate->eval_tuptable->tupdesc->natts != 1)
-       ereport(ERROR,
-               (errcode(ERRCODE_SYNTAX_ERROR),
-                errmsg_plural("query \"%s\" returned %d column",
-                              "query \"%s\" returned %d columns",
-                              estate->eval_tuptable->tupdesc->natts,
-                              expr->query,
-                              estate->eval_tuptable->tupdesc->natts)));
 
    /*
-    * Return the result and its type
+    * Return the single result Datum.
     */
-   *rettype = SPI_gettypeid(estate->eval_tuptable->tupdesc, 1);
    return SPI_getbinval(estate->eval_tuptable->vals[0],
                         estate->eval_tuptable->tupdesc, 1, isNull);
 }