Parenthesize macro arguments safely. I see no bug among the current

uses of PG_DETOAST_DATUM_SLICE, but it's clearly trouble waiting to
happen.

diff --git a/src/include/fmgr.h b/src/include/fmgr.h
index a2316264783620c9b9af56cd296965b40a3f05dc..a57439ee258f22b6777b507e168c9e7c2168e61b 100644 (file)
--- a/src/include/fmgr.h
+++ b/src/include/fmgr.h
@@ -179,7 +179,7 @@ extern struct varlena *pg_detoast_datum_packed(struct varlena * datum);
        pg_detoast_datum_copy((struct varlena *) DatumGetPointer(datum))
 #define PG_DETOAST_DATUM_SLICE(datum,f,c) \
                pg_detoast_datum_slice((struct varlena *) DatumGetPointer(datum), \
-               (int32) f, (int32) c)
+               (int32) (f), (int32) (c))
 /* WARNING -- unaligned pointer */
 #define PG_DETOAST_DATUM_PACKED(datum) \
        pg_detoast_datum_packed((struct varlena *) DatumGetPointer(datum))