Our version of getopt_long does not set optarg upon detecting an error, as

opposed to what other versions apparently do, so it's not safe to print an
error message.  Besides, getopt_long itself already did, so it's redundant
anyway.

diff --git a/src/bin/pg_ctl/pg_ctl.c b/src/bin/pg_ctl/pg_ctl.c
index 39f9be98bed035c2ba4998b77caa060ba4f17511..a45f58883f46e90e449a7cfbbf0e58ee707907db 100644 (file)
--- a/src/bin/pg_ctl/pg_ctl.c
+++ b/src/bin/pg_ctl/pg_ctl.c
@@ -1418,7 +1418,7 @@ main(int argc, char **argv)
                                        wait_set = true;
                                        break;
                                default:
-                                       write_stderr(_("%s: invalid option %s\n"), progname, optarg);
+                                       /* getopt_long already issued a suitable error message */
                                        do_advice();
                                        exit(1);
                        }