> Gavin Sherry <swm@linuxworld.com.au> writes:

> > I ran across this yesterday on HEAD:
>
> > template1=# grant select on foo, foo to swm;
> > ERROR:  tuple already updated by self
>
> Seems to fail similarly in every version back to 7.2; probably further,
> but that's all I have running at the moment.
>
> > We could do away with the error by producing a unique list of object names
> > -- but that would impose an extra cost on the common case.
>
> CommandCounterIncrement in the GRANT loop would be easier, likely.
> I'm having a hard time getting excited about it though...

Yeah, its not that exciting but that error message would throw your
average user.

I've attached a patch which calls CommandCounterIncrement() in each of the
grant loops.

Gavin Sherry

diff --git a/src/backend/catalog/aclchk.c b/src/backend/catalog/aclchk.c
index 3185f63c14f141a3e5b3444476ad092705fa99d8..119e1fa9171dad9b9d99ac7d3a2dfaf0a85eb0c1 100644 (file)
--- a/src/backend/catalog/aclchk.c
+++ b/src/backend/catalog/aclchk.c
@@ -388,6 +388,9 @@ ExecuteGrantStmt_Relation(GrantStmt *stmt)
                pfree(new_acl);
 
                heap_close(relation, RowExclusiveLock);
+
+               /* prevent error when processing duplicate objects */
+               CommandCounterIncrement();
        }
 }
 
@@ -565,6 +568,9 @@ ExecuteGrantStmt_Database(GrantStmt *stmt)
                heap_endscan(scan);
 
                heap_close(relation, RowExclusiveLock);
+
+               /* prevent error when processing duplicate objects */
+               CommandCounterIncrement();
        }
 }
 
@@ -738,6 +744,9 @@ ExecuteGrantStmt_Function(GrantStmt *stmt)
                pfree(new_acl);
 
                heap_close(relation, RowExclusiveLock);
+
+               /* prevent error when processing duplicate objects */
+               CommandCounterIncrement();
        }
 }
 
@@ -920,6 +929,9 @@ ExecuteGrantStmt_Language(GrantStmt *stmt)
                pfree(new_acl);
 
                heap_close(relation, RowExclusiveLock);
+
+               /* prevent error when processing duplicate objects */
+               CommandCounterIncrement();
        }
 }
 
@@ -1093,6 +1105,9 @@ ExecuteGrantStmt_Namespace(GrantStmt *stmt)
                pfree(new_acl);
 
                heap_close(relation, RowExclusiveLock);
+
+               /* prevent error when processing duplicate objects */
+               CommandCounterIncrement();
        }
 }
 
@@ -1269,6 +1284,9 @@ ExecuteGrantStmt_Tablespace(GrantStmt *stmt)
 
                heap_endscan(scan);
                heap_close(relation, RowExclusiveLock);
+
+               /* prevent error when processing duplicate objects */
+               CommandCounterIncrement();
        }
 }