Fix an error in the original coding of holdable cursors: PersistHoldablePortal

thought that it didn't have to reposition the underlying tuplestore if the
portal is atEnd.  But this is not so, because tuplestores have separate read
and write cursors ... and the read cursor hasn't moved from the start.
This mistake explains bug #2970 from William Zhang.

Note: the coding here is pretty inefficient, but given that no one has noticed
this bug until now, I'd say hardly anyone uses the case where the cursor has
been advanced before being persisted.  So maybe it's not worth worrying about.

diff --git a/src/backend/commands/portalcmds.c b/src/backend/commands/portalcmds.c
index cb327dae268da85cdb22ac2a1ed8c99aaf347536..bfb6b8c1ba5e68f5aef346f68bfecd4154242eea 100644 (file)
--- a/src/backend/commands/portalcmds.c
+++ b/src/backend/commands/portalcmds.c
@@ -385,15 +385,30 @@ PersistHoldablePortal(Portal portal)
                ExecutorEnd(queryDesc);
 
                /*
-                * Reset the position in the result set: ideally, this could be
+                * Set the position in the result set: ideally, this could be
                 * implemented by just skipping straight to the tuple # that we need
                 * to be at, but the tuplestore API doesn't support that. So we start
                 * at the beginning of the tuplestore and iterate through it until we
-                * reach where we need to be.  FIXME someday?
+                * reach where we need to be.  FIXME someday?  (Fortunately, the
+                * typical case is that we're supposed to be at or near the start
+                * of the result set, so this isn't as bad as it sounds.)
                 */
                MemoryContextSwitchTo(portal->holdContext);
 
-               if (!portal->atEnd)
+               if (portal->atEnd)
+               {
+                       /* we can handle this case even if posOverflow */
+                       HeapTuple       tup;
+                       bool            should_free;
+
+                       while ((tup = tuplestore_gettuple(portal->holdStore, true,
+                                                                                         &should_free)) != NULL)
+                       {
+                               if (should_free)
+                                       pfree(tup);
+                       }
+               }
+               else
                {
                        long            store_pos;