Fix shared library creation to work properly on AIX. Albe Laurenz

diff --git a/src/Makefile.global.in b/src/Makefile.global.in
index 364c3eb4ac227bef6a8464d053d1c63ae5a5664c..50f33f2172f562c703dbb89e0e854d5c4df411d4 100644 (file)
--- a/src/Makefile.global.in
+++ b/src/Makefile.global.in
@@ -345,13 +345,6 @@ libpq := -L$(libpq_builddir) -lpq
 ifeq ($(enable_shared), no)
 libpq += $(filter -lintl -lssl -lcrypto -lkrb5 -lcrypt, $(LIBS)) \
        $(LDAP_LIBS_FE) $(PTHREAD_LIBS)
-else
-# On AIX even shared libraries do not remember their required libs,
-# so again add in what libpq depends on.
-ifeq ($(PORTNAME), aix)
-libpq += $(filter -lintl -lssl -lcrypto -lkrb5 -lcrypt, $(LIBS)) \
-       $(LDAP_LIBS_FE) $(PTHREAD_LIBS)
-endif
 endif
 
 # This macro is for use by client executables (not libraries) that use libpq.

diff --git a/src/Makefile.shlib b/src/Makefile.shlib
index 8b425a0002745cc489e3e1fb23aac5e5c23f1d8a..62e2ef458d7e89ec6872e1510e2e3a5c2da562ec 100644 (file)
--- a/src/Makefile.shlib
+++ b/src/Makefile.shlib
@@ -96,8 +96,8 @@ override CFLAGS += $(CFLAGS_SL)
 soname = lib$(NAME)$(DLSUFFIX).$(SO_MAJOR_VERSION)
 
 ifeq ($(PORTNAME), aix)
-  shlib                        = lib$(NAME)$(DLSUFFIX)
-#   SHLIB_LINK         += -lc
+  shlib                        = lib$(NAME)$(DLSUFFIX).$(SO_MAJOR_VERSION)
+  haslibarule   = yes
 endif
 
 ifeq ($(PORTNAME), darwin)
@@ -295,9 +295,13 @@ endif
 else # PORTNAME == aix
 
 # AIX case
-$(shlib): lib$(NAME).a
+$(shlib) lib$(NAME).a: $(OBJS)
+       $(LINK.static) lib$(NAME).a $^
+       $(RANLIB) lib$(NAME).a
        $(MKLDEXPORT) lib$(NAME).a > lib$(NAME)$(EXPSUFF)
-       $(COMPILER) $(LDFLAGS_NO_L) $(LDFLAGS_SL) -o $@ $< -Wl,-bE:lib$(NAME)$(EXPSUFF) $(SHLIB_LINK)
+       $(COMPILER) $(LDFLAGS_NO_L) $(LDFLAGS_SL) -o $(shlib) lib$(NAME).a -Wl,-bE:lib$(NAME)$(EXPSUFF) $(SHLIB_LINK)
+       rm -f lib$(NAME).a
+       $(AR) $(AROPT) lib$(NAME).a $(shlib)
        
 endif # PORTNAME == aix
 
@@ -350,6 +354,7 @@ endif
 
 ifeq ($(enable_shared), yes)
 install-lib-shared: $(shlib)
+ifneq ($(PORTNAME), aix)               # we don't install $(shlib) on AIX
        $(INSTALL_SHLIB) $< '$(DESTDIR)$(libdir)/$(shlib)'
 ifneq ($(PORTNAME), cygwin)
 ifneq ($(PORTNAME), win32)
@@ -365,6 +370,7 @@ ifneq ($(shlib), $(shlib_bare))
 endif
 endif # not win32
 endif # not cygwin
+endif # not aix
 endif # enable_shared
 
 

diff --git a/src/interfaces/ecpg/test/Makefile.regress b/src/interfaces/ecpg/test/Makefile.regress
index 31f767a1c499073106f5432857d575fc6b1be35d..c5e017e74a99785867d4d9aa89663e14f684e4b5 100644 (file)
--- a/src/interfaces/ecpg/test/Makefile.regress
+++ b/src/interfaces/ecpg/test/Makefile.regress
@@ -2,8 +2,8 @@ override CPPFLAGS := -I../../include -I$(top_srcdir)/src/interfaces/ecpg/include
        -I$(libpq_srcdir) $(CPPFLAGS) 
 override CFLAGS += $(PTHREAD_CFLAGS) 
 
-override LDFLAGS := -L../../ecpglib -L../../pgtypeslib -L../../../libpq $(LDFLAGS)
-override LIBS := -lpgtypes -lecpg -lpq $(LIBS) $(PTHREAD_LIBS)
+override LDFLAGS := -L../../ecpglib -L../../pgtypeslib $(LDFLAGS)
+override LIBS := -lecpg -lpgtypes $(libpq) $(LIBS) $(PTHREAD_LIBS)
 
 ECPG = ../../preproc/ecpg -I$(srcdir)/../../include
 

diff --git a/src/interfaces/ecpg/test/compat_informix/Makefile b/src/interfaces/ecpg/test/compat_informix/Makefile
index 05ed3cfd8cc46c3a3ae0b7162c3a2be60487dfc6..f57a190c4bdc283a011283d76bbb3687ac6a69ab 100644 (file)
--- a/src/interfaces/ecpg/test/compat_informix/Makefile
+++ b/src/interfaces/ecpg/test/compat_informix/Makefile
@@ -3,11 +3,12 @@ top_builddir = ../../../../..
 include $(top_builddir)/src/Makefile.global
 include $(top_srcdir)/$(subdir)/../Makefile.regress
 
-# special informix compatiblity switches
+# special informix compatibility switches
 ECPG += -C INFORMIX
 ECPG_NOIND  = $(ECPG) -r no_indicator
-override LDFLAGS += -L../../compatlib
-override LIBS += $(LIBS) -lecpg_compat
+
+override LDFLAGS := -L../../compatlib $(LDFLAGS)
+override LIBS := -lecpg_compat $(LIBS)
 
 TESTS = test_informix test_informix.c \
         test_informix2 test_informix2.c \

diff --git a/src/interfaces/ecpg/test/pg_regress.sh b/src/interfaces/ecpg/test/pg_regress.sh
index d7363f1e470d40032fcd8469cddabd1e254360d6..3ae0f3fbcfa7c359db491d474e35a213b5dcb192 100644 (file)
--- a/src/interfaces/ecpg/test/pg_regress.sh
+++ b/src/interfaces/ecpg/test/pg_regress.sh
@@ -322,6 +322,7 @@ do_temp_install(){
     # Set up shared library paths, needed by psql and pg_encoding
     # (if you run multibyte).  LD_LIBRARY_PATH covers many platforms.
     # DYLD_LIBRARY_PATH works on Darwin, and maybe other Mach-based systems.
+    # LIBPATH is for AIX.
     # Feel free to account for others as well.
     # ----------
 
@@ -339,6 +340,13 @@ do_temp_install(){
     fi
     export DYLD_LIBRARY_PATH
 
+    if [ -n "$LIBPATH" ]; then
+        LIBPATH="$libdir:$LIBPATH"
+    else
+        LIBPATH=$libdir
+    fi
+    export LIBPATH
+
     # ----------
     # Windows needs shared libraries in PATH. (Only those linked into
     # executables, not dlopen'ed ones)

diff --git a/src/makefiles/Makefile.aix b/src/makefiles/Makefile.aix
index 2a75a24aeac957e040503179a5ae0eed26075d54..8a789352b63ca20c3daee92b5c229804cdddc026 100644 (file)
--- a/src/makefiles/Makefile.aix
+++ b/src/makefiles/Makefile.aix
@@ -5,6 +5,15 @@ MAKE_EXPORTS= true
 RANLIB= touch
 AROPT = crs
 
+# -blibpath must contain ALL directories where we should look for libraries
+libpath := $(shell echo $(subst -L,:,$(filter -L/%,$(LDFLAGS))) | sed -e's/ //g'):/usr/lib:/lib
+
+ifeq ($(host_os), aix3.2.5)
+       rpath = -L$(rpathdir)
+else
+       rpath = -Wl,-blibpath:$(rpathdir)$(libpath)
+endif
+
 DLSUFFIX = .so
 ifeq ($(host_os), aix3.2.5)
 ifneq ($(GCC), yes)

diff --git a/src/test/regress/pg_regress.c b/src/test/regress/pg_regress.c
index 147b1d7cd2ba125bec62b018468370713a22fe59..e12ddb4bd8c7f690b66f39a72584df685f6d68a1 100644 (file)
--- a/src/test/regress/pg_regress.c
+++ b/src/test/regress/pg_regress.c
@@ -507,12 +507,14 @@ initialize_environment(void)
                 * Set up shared library paths to include the temp install.
                 *
                 * LD_LIBRARY_PATH covers many platforms.  DYLD_LIBRARY_PATH works on
-                * Darwin, and maybe other Mach-based systems.  Windows needs shared
-                * libraries in PATH.  (Only those linked into executables, not
-                * dlopen'ed ones)  Feel free to account for others as well.
+                * Darwin, and maybe other Mach-based systems.  LIBPATH is for AIX.
+                * Windows needs shared libraries in PATH (only those linked into
+                * executables, not dlopen'ed ones).
+                * Feel free to account for others as well.
                 */
                add_to_path("LD_LIBRARY_PATH", ':', libdir);
                add_to_path("DYLD_LIBRARY_PATH", ':', libdir);
+               add_to_path("LIBPATH", ':', libdir);
 #if defined(WIN32) || defined(__CYGWIN__)
                add_to_path("PATH", ';', libdir);
 #endif