Always schema-qualify the name of a function referenced in CREATE CAST.

The former coding failed if the cast function was not in the pg_catalog
schema.  How'd this escape detection?

diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index d48eed494d809dd1db4d1ba0238712132aa04a06..bb6c753600fea7ff68bb99d07793fe11a62c32e0 100644 (file)
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -4083,8 +4083,16 @@ dumpCasts(Archive *fout,
                if (strcmp(castfunc, "0") == 0)
                        appendPQExpBuffer(defqry, "WITHOUT FUNCTION");
                else
-                       appendPQExpBuffer(defqry, "WITH FUNCTION %s",
-                                                 format_function_signature(&finfo[fidx], true));
+               {
+                       /*
+                        * Always qualify the function name, in case it is not in
+                        * pg_catalog schema (format_function_signature won't qualify it).
+                        */
+                       appendPQExpBuffer(defqry, "WITH FUNCTION %s.",
+                                                         fmtId(finfo[fidx].pronamespace->nspname));
+                       appendPQExpBuffer(defqry, "%s",
+                                                         format_function_signature(&finfo[fidx], true));
+               }
 
                if (strcmp(castcontext, "a") == 0)
                        appendPQExpBuffer(defqry, " AS ASSIGNMENT");