The control file does not contain enableIntTimes anymore
authorChristoph Berg <myon@debian.org>
Sun, 22 Oct 2017 17:16:24 +0000 (19:16 +0200)
committerChristoph Berg <myon@debian.org>
Sun, 22 Oct 2017 17:16:24 +0000 (19:16 +0200)
PG10 gets rid of controlData->enableIntTimes, remove it in pg_filedump
as well. We could add try adding #ifs to still show it for older major
versions, but given that pg_filedump is cross-version compatible for
dumping the recent major's control files except for this change, it
seems more prudent to simply remove it. We don't show other fields like
float4ByVal either, and pg_controldata is a better tool for control file
inspection anyway, so keep the logic in pg_filedump simple.

pg_filedump.c

index ccc7ebaa0215988e7f924bd09dd7e1b43bb2c53e..f900eda26621cdb75c301409f2fbd6ad53a1b720 100644 (file)
@@ -1616,8 +1616,7 @@ FormatControl()
                           "            XLOG Segment Size: %u\n"
                           "    Maximum Identifier Length: %u\n"
                           "           Maximum Index Keys: %u\n"
-                          "             TOAST Chunk Size: %u\n"
-                          "   Date and Time Type Storage: %s\n\n",
+                          "             TOAST Chunk Size: %u\n\n",
                           EQ_CRC32C(crcLocal,
                                                controlData->crc) ? "Correct" : "Not Correct",
                           controlData->pg_control_version,
@@ -1646,9 +1645,7 @@ FormatControl()
                           controlData->xlog_seg_size,
                           controlData->nameDataLen,
                           controlData->indexMaxKeys,
-                          controlData->toast_max_chunk_size,
-                          (controlData->enableIntTimes ?
-                               "64 bit Integers" : "Floating Point"));
+                          controlData->toast_max_chunk_size);
        }
        else
        {