Suppress useless warning on pre-XP versions of Windows. Magnus

diff --git a/src/bin/pg_ctl/pg_ctl.c b/src/bin/pg_ctl/pg_ctl.c
index 21978276c0f8e5ece177b649fe50770c023c2178..d7c50399e99f9f37f63e75257a20d6996c3b1e01 100644 (file)
--- a/src/bin/pg_ctl/pg_ctl.c
+++ b/src/bin/pg_ctl/pg_ctl.c
@@ -1277,7 +1277,15 @@ CreateRestrictedProcess(char *cmd, PROCESS_INFORMATION *processInfo)
     /* Verify that we found all functions */
     if (_IsProcessInJob == NULL || _CreateJobObject == NULL || _SetInformationJobObject == NULL || _AssignProcessToJobObject == NULL || _QueryInformationJobObject == NULL)
     {
-        write_stderr("WARNING: Unable to locate all job object functions in system API!\n");
+               /* IsProcessInJob() is not available on < WinXP, so there is no need to log the error every time in that case */
+               OSVERSIONINFO osv;
+
+               osv.dwOSVersionInfoSize = sizeof(osv);
+               if (!GetVersionEx(&osv) || /* could not get version */
+                       (osv.dwMajorVersion == 5 && osv.dwMinorVersion > 0) || /* 5.1=xp, 5.2=2003, etc */
+                       osv.dwMajorVersion > 5) /* anything newer should have the API */
+                       /* Log error if we can't get version, or if we're on WinXP/2003 or newer */
+                       write_stderr("WARNING: Unable to locate all job object functions in system API!\n");
     } 
     else
     {