Code review for --quote-all-identifiers patch: add missing --help documentation

for new pg_dump/pg_dumpall parameters, make a couple of trivial stylistic
adjustments to make the code follow usual project style.

diff --git a/src/backend/utils/adt/ruleutils.c b/src/backend/utils/adt/ruleutils.c
index e06ac5697b7344788f1d65c6773fcdda3c54ee8c..0887c705f52b8e09f7668bacc1e1c388be64de33 100644 (file)
--- a/src/backend/utils/adt/ruleutils.c
+++ b/src/backend/utils/adt/ruleutils.c
@@ -9,7 +9,7 @@
  *
  *
  * IDENTIFICATION
- *       $PostgreSQL: pgsql/src/backend/utils/adt/ruleutils.c,v 1.329 2010/07/22 01:22:33 rhaas Exp $
+ *       $PostgreSQL: pgsql/src/backend/utils/adt/ruleutils.c,v 1.330 2010/08/03 19:24:04 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -132,7 +132,9 @@ static SPIPlanPtr plan_getrulebyoid = NULL;
 static const char *query_getrulebyoid = "SELECT * FROM pg_catalog.pg_rewrite WHERE oid = $1";
 static SPIPlanPtr plan_getviewrule = NULL;
 static const char *query_getviewrule = "SELECT * FROM pg_catalog.pg_rewrite WHERE ev_class = $1 AND rulename = $2";
-bool quote_all_identifiers;
+
+/* GUC parameters */
+bool           quote_all_identifiers = false;
 
 
 /* ----------

diff --git a/src/bin/pg_dump/dumputils.c b/src/bin/pg_dump/dumputils.c
index 64e5b1df104e323c49cf4ff92ca8dabcbcc4bf49..176abb2f162c8bf3d544c4e016599cde2fddc210 100644 (file)
--- a/src/bin/pg_dump/dumputils.c
+++ b/src/bin/pg_dump/dumputils.c
@@ -8,7 +8,7 @@
  * Portions Copyright (c) 1996-2010, PostgreSQL Global Development Group
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- * $PostgreSQL: pgsql/src/bin/pg_dump/dumputils.c,v 1.57 2010/07/22 01:22:34 rhaas Exp $
+ * $PostgreSQL: pgsql/src/bin/pg_dump/dumputils.c,v 1.58 2010/08/03 19:24:04 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -21,6 +21,9 @@
 #include "parser/keywords.h"
 
 
+int            quote_all_identifiers = 0;
+
+
 #define supports_grant_options(version) ((version) >= 70400)
 
 static bool parseAclItem(const char *item, const char *type,
@@ -36,8 +39,6 @@ static bool parallel_init_done = false;
 static DWORD tls_index;
 #endif
 
-int quote_all_identifiers;
-
 void
 init_parallel_dump_utils(void)
 {

diff --git a/src/bin/pg_dump/dumputils.h b/src/bin/pg_dump/dumputils.h
index 3d22a46323e76b5fb8a9b6483757b810c484a567..63bd02c156df67dd3b44464df54bbd9ba79c128e 100644 (file)
--- a/src/bin/pg_dump/dumputils.h
+++ b/src/bin/pg_dump/dumputils.h
@@ -8,7 +8,7 @@
  * Portions Copyright (c) 1996-2010, PostgreSQL Global Development Group
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- * $PostgreSQL: pgsql/src/bin/pg_dump/dumputils.h,v 1.30 2010/07/22 01:22:34 rhaas Exp $
+ * $PostgreSQL: pgsql/src/bin/pg_dump/dumputils.h,v 1.31 2010/08/03 19:24:04 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -19,6 +19,8 @@
 #include "libpq-fe.h"
 #include "pqexpbuffer.h"
 
+extern int quote_all_identifiers;
+
 extern void init_parallel_dump_utils(void);
 extern const char *fmtId(const char *identifier);
 extern void appendStringLiteral(PQExpBuffer buf, const char *str,
@@ -46,6 +48,4 @@ extern bool processSQLNamePattern(PGconn *conn, PQExpBuffer buf,
                                          const char *schemavar, const char *namevar,
                                          const char *altnamevar, const char *visibilityrule);
 
-extern int quote_all_identifiers;
-
 #endif   /* DUMPUTILS_H */

diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index 666312fb56a3ca375650620b4c206866f9b0a115..1fd43b55e17447da2e2a1b745b344e47ad30d604 100644 (file)
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -25,7 +25,7 @@
  *     http://archives.postgresql.org/pgsql-bugs/2010-02/msg00187.php
  *
  * IDENTIFICATION
- *       $PostgreSQL: pgsql/src/bin/pg_dump/pg_dump.c,v 1.583 2010/07/22 01:22:34 rhaas Exp $
+ *       $PostgreSQL: pgsql/src/bin/pg_dump/pg_dump.c,v 1.584 2010/08/03 19:24:04 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -836,6 +836,7 @@ help(const char *progname)
        printf(_("  --disable-dollar-quoting    disable dollar quoting, use SQL standard quoting\n"));
        printf(_("  --disable-triggers          disable triggers during data-only restore\n"));
        printf(_("  --no-tablespaces            do not dump tablespace assignments\n"));
+       printf(_("  --quote-all-identifiers     quote all identifiers, even if not keywords\n"));
        printf(_("  --role=ROLENAME             do SET ROLE before dump\n"));
        printf(_("  --use-set-session-authorization\n"
                         "                              use SET SESSION AUTHORIZATION commands instead of\n"

diff --git a/src/bin/pg_dump/pg_dumpall.c b/src/bin/pg_dump/pg_dumpall.c
index 260b6684edb5bd957756942d6f55ec7f70248134..c9cbc8e73f858386fbeb9b4e6a53c0d1cdf34075 100644 (file)
--- a/src/bin/pg_dump/pg_dumpall.c
+++ b/src/bin/pg_dump/pg_dumpall.c
@@ -6,7 +6,7 @@
  * Portions Copyright (c) 1994, Regents of the University of California
  *
  *
- * $PostgreSQL: pgsql/src/bin/pg_dump/pg_dumpall.c,v 1.136 2010/07/22 01:25:01 rhaas Exp $
+ * $PostgreSQL: pgsql/src/bin/pg_dump/pg_dumpall.c,v 1.137 2010/08/03 19:24:05 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -564,6 +564,7 @@ help(void)
        printf(_("  --disable-dollar-quoting    disable dollar quoting, use SQL standard quoting\n"));
        printf(_("  --disable-triggers          disable triggers during data-only restore\n"));
        printf(_("  --no-tablespaces            do not dump tablespace assignments\n"));
+       printf(_("  --quote-all-identifiers     quote all identifiers, even if not keywords\n"));
        printf(_("  --role=ROLENAME             do SET ROLE before dump\n"));
        printf(_("  --use-set-session-authorization\n"
                         "                              use SET SESSION AUTHORIZATION commands instead of\n"