Get rid of perror(), substitute some better phrased error messages.

malloc() doesn't set errno, so most uses were buggy anyway.

diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c
index 571e1e717eaaea57da5a3d141afe31f8e18aeeed..77878c217f7b2aeea5126f29780da31c182108bc 100644 (file)
--- a/src/bin/initdb/initdb.c
+++ b/src/bin/initdb/initdb.c
@@ -2472,7 +2472,8 @@ main(int argc, char *argv[])
 
                        if (chmod(pg_data, 0700) != 0)
                        {
-                               perror(pg_data);
+                               fprintf(stderr, _("%s: could not change permissions of directory »%s«: %s\n"),
+                                               progname, pg_data, strerror(errno));
                                exit_nicely();
                        }
                        else
@@ -2493,7 +2494,8 @@ main(int argc, char *argv[])
 
                default:
                        /* Trouble accessing directory */
-                       perror(pg_data);
+                       fprintf(stderr, _("%s: could not access directory »%s«: %s\n"),
+                                       progname, pg_data, strerror(errno));
                        exit_nicely();
        }
 

diff --git a/src/bin/psql/print.c b/src/bin/psql/print.c
index 9b49ec8e741a339b6aa4f5e4f976f23d26f953bf..e8a978530ef259a191e0d6186c38fe246b1f2de1 100644 (file)
--- a/src/bin/psql/print.c
+++ b/src/bin/psql/print.c
@@ -227,14 +227,14 @@ print_aligned_text(const char *title, const char *const * headers,
                widths = calloc(col_count, sizeof(*widths));
                if (!widths)
                {
-                       perror("calloc");
+                       fprintf(stderr, gettext("out of memory\n"));
                        exit(EXIT_FAILURE);
                }
 
                head_w = calloc(col_count, sizeof(*head_w));
                if (!head_w)
                {
-                       perror("calloc");
+                       fprintf(stderr, gettext("out of memory\n"));
                        exit(EXIT_FAILURE);
                }
        }
@@ -253,7 +253,7 @@ print_aligned_text(const char *title, const char *const * headers,
                cell_w = calloc(cell_count, sizeof(*cell_w));
                if (!cell_w)
                {
-                       perror("calloc");
+                       fprintf(stderr, gettext("out of memory\n"));
                        exit(EXIT_FAILURE);
                }
        }
@@ -437,7 +437,7 @@ print_aligned_vertical(const char *title, const char *const * headers,
                head_w = calloc(col_count, sizeof(*head_w));
                if (!head_w)
                {
-                       perror("calloc");
+                       fprintf(stderr, gettext("out of memory\n"));
                        exit(EXIT_FAILURE);
                }
        }
@@ -461,7 +461,7 @@ print_aligned_vertical(const char *title, const char *const * headers,
                cell_w = calloc(cell_count, sizeof(*cell_w));
                if (!cell_w)
                {
-                       perror("calloc");
+                       fprintf(stderr, gettext("out of memory\n"));
                        exit(EXIT_FAILURE);
                }
        }
@@ -485,7 +485,7 @@ print_aligned_vertical(const char *title, const char *const * headers,
        divider = malloc(hwidth + dwidth + 10);
        if (!divider)
        {
-               perror("malloc");
+               fprintf(stderr, gettext("out of memory\n"));
                exit(EXIT_FAILURE);
        }
        divider[0] = '\0';
@@ -514,7 +514,7 @@ print_aligned_vertical(const char *title, const char *const * headers,
 
                                if (!record_str)
                                {
-                                       perror("malloc");
+                                       fprintf(stderr, gettext("out of memory\n"));
                                        exit(EXIT_FAILURE);
                                }
 
@@ -532,7 +532,7 @@ print_aligned_vertical(const char *title, const char *const * headers,
 
                                        if (!div_copy)
                                        {
-                                               perror("malloc");
+                                               fprintf(stderr, gettext("out of memory\n"));
                                                exit(EXIT_FAILURE);
                                        }
 
@@ -1153,7 +1153,7 @@ printQuery(const PGresult *result, const printQueryOpt *opt, FILE *fout)
        headers = calloc(nfields + 1, sizeof(*headers));
        if (!headers)
        {
-               perror("calloc");
+               fprintf(stderr, gettext("out of memory\n"));
                exit(EXIT_FAILURE);
        }
 
@@ -1165,7 +1165,7 @@ printQuery(const PGresult *result, const printQueryOpt *opt, FILE *fout)
        cells = calloc(ncells + 1, sizeof(*cells));
        if (!cells)
        {
-               perror("calloc");
+               fprintf(stderr, gettext("out of memory\n"));
                exit(EXIT_FAILURE);
        }
 
@@ -1186,14 +1186,14 @@ printQuery(const PGresult *result, const printQueryOpt *opt, FILE *fout)
                footers = calloc(2, sizeof(*footers));
                if (!footers)
                {
-                       perror("calloc");
+                       fprintf(stderr, gettext("out of memory\n"));
                        exit(EXIT_FAILURE);
                }
 
                footers[0] = malloc(100);
                if (!footers[0])
                {
-                       perror("malloc");
+                       fprintf(stderr, gettext("out of memory\n"));
                        exit(EXIT_FAILURE);
                }
                if (PQntuples(result) == 1)
@@ -1208,7 +1208,7 @@ printQuery(const PGresult *result, const printQueryOpt *opt, FILE *fout)
        align = calloc(nfields + 1, sizeof(*align));
        if (!align)
        {
-               perror("calloc");
+               fprintf(stderr, gettext("out of memory\n"));
                exit(EXIT_FAILURE);
        }
 

diff --git a/src/bin/scripts/common.c b/src/bin/scripts/common.c
index dc6c26aa4b51ca51ac4f90717fd90837244fc50c..c91707701db80c9b3e7e43982c093c5f64f57f92 100644 (file)
--- a/src/bin/scripts/common.c
+++ b/src/bin/scripts/common.c
@@ -30,7 +30,8 @@ get_user_name(const char *progname)
        pw = getpwuid(getuid());
        if (!pw)
        {
-               perror(progname);
+               fprintf(stderr, _("%s: could not obtain information about current user: %s"),
+                               progname, strerror(errno));
                exit(1);
        }
        return pw->pw_name;
@@ -40,7 +41,8 @@ get_user_name(const char *progname)
 
        if (!GetUserName(username, &len))
        {
-               perror(progname);
+               fprintf(stderr, _("%s: could not get current user name: %s"),
+                               progname, strerror(errno));
                exit(1);
        }
        return username;

diff --git a/src/interfaces/ecpg/preproc/ecpg.c b/src/interfaces/ecpg/preproc/ecpg.c
index c3f16c958779875d38acd0e203314d953e989867..85435c3317ef8594c13a39fb6bf0db8cf03b821f 100644 (file)
--- a/src/interfaces/ecpg/preproc/ecpg.c
+++ b/src/interfaces/ecpg/preproc/ecpg.c
@@ -154,7 +154,8 @@ main(int argc, char *const argv[])
                                        yyout = fopen(optarg, PG_BINARY_W);
 
                                if (yyout == NULL)
-                                       perror(optarg);
+                                       fprintf(stderr, "%s: could not open file \"%s\": %s\n",
+                                                       progname, optarg, strerror(errno));
                                else
                                        out_option = 1;
                                break;
@@ -304,7 +305,8 @@ main(int argc, char *const argv[])
                                        yyout = fopen(output_filename, PG_BINARY_W);
                                        if (yyout == NULL)
                                        {
-                                               perror(output_filename);
+                                               fprintf(stderr, "%s: could not open file \"%s\": %s\n",
+                                                               progname, output_filename, strerror(errno));
                                                free(output_filename);
                                                free(input_filename);
                                                continue;
@@ -313,7 +315,8 @@ main(int argc, char *const argv[])
                        }
 
                        if (yyin == NULL)
-                               perror(argv[fnr]);
+                               fprintf(stderr, "%s: could not open file \"%s\": %s\n",
+                                               progname, argv[fnr], strerror(errno));
                        else
                        {
                                struct cursor *ptr;

diff --git a/src/interfaces/libpq/fe-auth.c b/src/interfaces/libpq/fe-auth.c
index 5955251b058d28aedc0bdf1cf8128d8d4dc7afa8..9af33f021e5f7c3cfcee0f083f96906024162a5b 100644 (file)
--- a/src/interfaces/libpq/fe-auth.c
+++ b/src/interfaces/libpq/fe-auth.c
@@ -527,7 +527,7 @@ pg_password_sendauth(PGconn *conn, const char *password, AuthRequest areq)
                                if (!(crypt_pwd = malloc(MD5_PASSWD_LEN + 1)) ||
                                        !(crypt_pwd2 = malloc(MD5_PASSWD_LEN + 1)))
                                {
-                                       perror("malloc");
+                                       fprintf(stderr, libpq_gettext("out of memory\n"));
                                        return STATUS_ERROR;
                                }
                                if (!EncryptMD5(password, conn->pguser,

diff --git a/src/interfaces/libpq/fe-print.c b/src/interfaces/libpq/fe-print.c
index 0b037d8cd07667abf59c518cd964db34acb7be02..114d6fc3fc49393115b5abcabb45f6ccc6ffc2ce 100644 (file)
--- a/src/interfaces/libpq/fe-print.c
+++ b/src/interfaces/libpq/fe-print.c
@@ -110,17 +110,17 @@ PQprint(FILE *fout,
                nTups = PQntuples(res);
                if (!(fieldNames = (const char **) calloc(nFields, sizeof(char *))))
                {
-                       perror("calloc");
+                       fprintf(stderr, libpq_gettext("out of memory\n"));
                        exit(1);
                }
                if (!(fieldNotNum = (unsigned char *) calloc(nFields, 1)))
                {
-                       perror("calloc");
+                       fprintf(stderr, libpq_gettext("out of memory\n"));
                        exit(1);
                }
                if (!(fieldMax = (int *) calloc(nFields, sizeof(int))))
                {
-                       perror("calloc");
+                       fprintf(stderr, libpq_gettext("out of memory\n"));
                        exit(1);
                }
                for (numFieldName = 0;
@@ -205,7 +205,7 @@ PQprint(FILE *fout,
                {
                        if (!(fields = (char **) calloc(nFields * (nTups + 1), sizeof(char *))))
                        {
-                               perror("calloc");
+                               fprintf(stderr, libpq_gettext("out of memory\n"));
                                exit(1);
                        }
                }
@@ -392,7 +392,7 @@ do_field(const PQprintOpt *po, const PGresult *res,
                                fieldMax[j] = plen;
                        if (!(fields[i * nFields + j] = (char *) malloc(plen + 1)))
                        {
-                               perror("malloc");
+                               fprintf(stderr, libpq_gettext("out of memory\n"));
                                exit(1);
                        }
                        strcpy(fields[i * nFields + j], pval);
@@ -463,7 +463,7 @@ do_header(FILE *fout, const PQprintOpt *po, const int nFields, int *fieldMax,
                border = malloc(tot + 1);
                if (!border)
                {
-                       perror("malloc");
+                       fprintf(stderr, libpq_gettext("out of memory\n"));
                        exit(1);
                }
                p = border;