Remove unnecessary UPDATE commands to assign explicit ACLs to functions

and PL languages during initdb.  The default permissions for these objects
are the same as what we were assigning anyway, so there is no need to
expend space in the catalogs on them.  The space cost is particularly
significant in pg_proc's indexes, which are bloated by about a factor of 2
by the full-table update, and can never really recover the space.
initdb not forced, since the change has no actual impact on behavior.

diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c
index bc3019b1d8f064a39d8ca1aa322920364cafda6d..6a6bb11fc7a74c56ba1acf41fa5cc18699898e51 100644 (file)
--- a/src/bin/initdb/initdb.c
+++ b/src/bin/initdb/initdb.c
@@ -1672,7 +1672,10 @@ setup_conversion(void)
 /*
  * Set up privileges
  *
- * We set most system catalogs and built-in functions as world-accessible.
+ * We mark most system catalogs as world-readable.  We don't currently have
+ * to touch functions, languages, or databases, because their default
+ * permissions are OK.
+ *
  * Some objects may require different permissions by default, so we
  * make sure we don't overwrite privilege sets that have already been
  * set (NOT NULL).
@@ -1687,12 +1690,6 @@ setup_privileges(void)
                "UPDATE pg_class "
                "  SET relacl = '{\"=r/\\\\\"$POSTGRES_SUPERUSERNAME\\\\\"\"}' "
                "  WHERE relkind IN ('r', 'v', 'S') AND relacl IS NULL;\n",
-               "UPDATE pg_proc "
-               "  SET proacl = '{\"=X/\\\\\"$POSTGRES_SUPERUSERNAME\\\\\"\"}' "
-               "  WHERE proacl IS NULL;\n",
-               "UPDATE pg_language "
-               "  SET lanacl = '{\"=U/\\\\\"$POSTGRES_SUPERUSERNAME\\\\\"\"}' "
-               "  WHERE lanpltrusted;\n",
                "GRANT USAGE ON SCHEMA pg_catalog TO PUBLIC;\n",
                "GRANT CREATE, USAGE ON SCHEMA public TO PUBLIC;\n",
                NULL