Recent changes got the sense of the notnull bit backwards in the 2.0

protocol output routines.  Mea culpa :-(.  Per report from Kris Jurka.

diff --git a/src/backend/access/common/printtup.c b/src/backend/access/common/printtup.c
index 48ed7a411ff5b7e806b8dda9851482563115d076..f28e9739ed28a21aaebce55da5a1faa2157f59e1 100644 (file)
--- a/src/backend/access/common/printtup.c
+++ b/src/backend/access/common/printtup.c
@@ -402,7 +402,7 @@ printtup_20(TupleTableSlot *slot, DestReceiver *self)
        k = 1 << 7;
        for (i = 0; i < natts; ++i)
        {
-               if (slot->tts_isnull[i])
+               if (!slot->tts_isnull[i])
                        j |= k;                         /* set bit if not null */
                k >>= 1;
                if (k == 0)                             /* end of byte? */
@@ -610,7 +610,7 @@ printtup_internal_20(TupleTableSlot *slot, DestReceiver *self)
        k = 1 << 7;
        for (i = 0; i < natts; ++i)
        {
-               if (slot->tts_isnull[i])
+               if (!slot->tts_isnull[i])
                        j |= k;                         /* set bit if not null */
                k >>= 1;
                if (k == 0)                             /* end of byte? */