Fix embarrassing bug in recent smgr refactoring patch: WAL records should

be written for *non*-temp tables only. Report and test case by Mark
Kirkwood and Simon Riggs.

diff --git a/src/backend/catalog/storage.c b/src/backend/catalog/storage.c
index 869effeef373155d9b2392c999b1507167fedb2f..e9008e3f2cc78eabcd373225c0d7d395c3117d37 100644 (file)
--- a/src/backend/catalog/storage.c
+++ b/src/backend/catalog/storage.c
@@ -106,7 +106,7 @@ RelationCreateStorage(RelFileNode rnode, bool istemp)
        srel = smgropen(rnode);
        smgrcreate(srel, MAIN_FORKNUM, false);
 
-       if (istemp)
+       if (!istemp)
        {
                /*
                 * Make an XLOG entry showing the file creation.  If we abort, the file
@@ -203,7 +203,7 @@ RelationTruncate(Relation rel, BlockNumber nblocks)
         * harmless failure to truncate, that could spell trouble at WAL replay,
         * into a certain PANIC.
         */
-       if (rel->rd_istemp)
+       if (!rel->rd_istemp)
        {
                /*
                 * Make an XLOG entry showing the file truncation.