Don't crash if cursor_to_xmlschema is used on a non-data-returning Portal.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 18 Sep 2023 18:27:47 +0000 (14:27 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 18 Sep 2023 18:27:47 +0000 (14:27 -0400)
commitec693a3f304cf91c717c0fe07abcd4185952fde5
tree628eabb3608d04514c134567d31aaab0b7d59e87
parent53630f12d39b9c5d98abb7bae4818715306422ed
Don't crash if cursor_to_xmlschema is used on a non-data-returning Portal.

cursor_to_xmlschema() assumed that any Portal must have a tupDesc,
which is not so.  Add a defensive check.

It's plausible that this mistake occurred because of the rather
poorly chosen name of the lookup function SPI_cursor_find(),
which in such cases is returning something that isn't very much
like a cursor.  Add some documentation to try to forestall future
errors of the same ilk.

Report and patch by Boyu Yang (docs changes by me).  Back-patch
to all supported branches.

Discussion: https://postgr.es/m/dd343010-c637-434c-a8cb-418f53bda3b8.yangboyu.yby@alibaba-inc.com
doc/src/sgml/spi.sgml
src/backend/utils/adt/xml.c