Further tweaking of PG_SYSROOT heuristics for macOS.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 20 Jan 2021 17:07:23 +0000 (12:07 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 20 Jan 2021 17:07:52 +0000 (12:07 -0500)
commitcbcf7b130f5e53e405c5b366e78a4b3d8ff5f642
tree9cbab4bc90819ae1d703b3dc9cdf65e84ec3ad3e
parent7dc3be9df86cfd2515e76c078347dccc9a929d0b
Further tweaking of PG_SYSROOT heuristics for macOS.

It emerges that in some phases of the moon (perhaps to do with
directory entry order?), xcrun will report that the SDK path is
  /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk
which is normally a symlink to a version-numbered sibling directory.
Our heuristic to skip non-version-numbered pathnames was rejecting
that, which is the wrong thing to do.  We'd still like to end up
with a version-numbered PG_SYSROOT value, but we can have that by
dereferencing the symlink.

Like the previous fix, back-patch to all supported versions.

Discussion: https://postgr.es/m/522433.1611089678@sss.pgh.pa.us
src/template/darwin