Always pass catalog id to the options validator function specified in
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Wed, 23 Dec 2009 12:24:16 +0000 (12:24 +0000)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Wed, 23 Dec 2009 12:24:16 +0000 (12:24 +0000)
commita1ffb012174d3dbd3b8b42bdba593f829d9b678e
treeab906827f63d65184f207c4163742768cdb87960
parent7826bd450b84bfc2fff7ed76895e7d53ce726766
Always pass catalog id to the options validator function specified in
CREATE FOREIGN DATA WRAPPER. Arguably it wasn't a bug because the
documentation said that it's passed the catalog ID or zero, but surely
we should provide it when it's known. And there isn't currently any
scenario where it's not known, and I can't imagine having one in the
future either, so better remove the "or zero" escape hatch and always
pass a valid catalog ID. Backpatch to 8.4.

Martin Pihlak
doc/src/sgml/ref/create_foreign_data_wrapper.sgml
src/backend/commands/foreigncmds.c
src/backend/foreign/foreign.c
src/test/regress/expected/foreign_data.out