Avoid memory size overflow when allocating backend activity buffer
authorMichael Paquier <michael@paquier.xyz>
Tue, 3 Oct 2023 06:37:18 +0000 (15:37 +0900)
committerMichael Paquier <michael@paquier.xyz>
Tue, 3 Oct 2023 06:37:18 +0000 (15:37 +0900)
commit75f31a3f26744ca71a4214d4ab0c7f6cac4a0421
treebcef34f78c8091a1e25ab2bce18345c34befc064
parenta06efbc3ac72a455a63635c9cbc56ad3338988cc
Avoid memory size overflow when allocating backend activity buffer

The code in charge of copying the contents of PgBackendStatus to local
memory could fail on memory allocation because of an overflow on the
amount of memory to use.  The overflow can happen when combining a high
value track_activity_query_size (max at 1MB) with a large
max_connections, when both multiplied get higher than INT32_MAX as both
parameters treated as signed integers.  This could for example trigger
with the following functions, all calling pgstat_read_current_status():
- pg_stat_get_backend_subxact()
- pg_stat_get_backend_idset()
- pg_stat_get_progress_info()
- pg_stat_get_activity()
- pg_stat_get_db_numbackends()

The change to use MemoryContextAllocHuge() has been introduced in
8d0ddccec636, so backpatch down to 12.

Author: Jakub Wartak
Discussion: https://postgr.es/m/CAKZiRmw8QSNVw2qNK-dznsatQqz+9DkCquxP0GHbbv1jMkGHMA@mail.gmail.com
Backpatch-through: 12
src/backend/utils/activity/backend_status.c