Fix arrays comparison in CompareOpclassOptions()
authorAlexander Korotkov <akorotkov@postgresql.org>
Mon, 11 Nov 2024 23:44:20 +0000 (01:44 +0200)
committerAlexander Korotkov <akorotkov@postgresql.org>
Mon, 11 Nov 2024 23:54:30 +0000 (01:54 +0200)
commit713b8546aba66be102bdd8b320c06ea3b2813fd9
tree87e6b1ea03630a97820b82e76855ab1c6d847a43
parent0c53d54c812cea0d840490fd107910ed949e18c2
Fix arrays comparison in CompareOpclassOptions()

The current code calls array_eq() and does not provide FmgrInfo.  This commit
provides initialization of FmgrInfo and uses C collation as the safe option
for text comparison because we don't know anything about the semantics of
opclass options.

Backpatch to 13, where opclass options were introduced.

Reported-by: Nicolas Maus
Discussion: https://postgr.es/m/18692-72ea398df3ec6712%40postgresql.org
Backpatch-through: 13
contrib/pg_trgm/expected/pg_trgm.out
contrib/pg_trgm/sql/pg_trgm.sql
src/backend/commands/indexcmds.c