Fix off-by-one Asserts in FreePageBtreeInsertInternal/Leaf.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 23 Oct 2025 16:32:06 +0000 (12:32 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 23 Oct 2025 16:32:35 +0000 (12:32 -0400)
commit05d8a0869ea491ff9e989750dd23e190e77698c4
tree90dcc6a2e57de37e4503a677cc90cf30ca0c6f0d
parent4cde7325924e84fbaaa4e404944af7753aa88174
Fix off-by-one Asserts in FreePageBtreeInsertInternal/Leaf.

These two functions expect there to be room to insert another item
in the FreePageBtree's array, but their assertions were too weak
to guarantee that.  This has little practical effect granting that
the callers are not buggy, but it seems to be misleading late-model
Coverity into complaining about possible array overrun.

Author: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/799984.1761150474@sss.pgh.pa.us
Backpatch-through: 13
src/backend/utils/mmgr/freepage.c